From owner-freebsd-stable@freebsd.org Thu May 10 14:41:10 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 619E6FCBABB for ; Thu, 10 May 2018 14:41:10 +0000 (UTC) (envelope-from vrwmiller@gmail.com) Received: from mail-ua0-x22d.google.com (mail-ua0-x22d.google.com [IPv6:2607:f8b0:400c:c08::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DAE268D984; Thu, 10 May 2018 14:41:09 +0000 (UTC) (envelope-from vrwmiller@gmail.com) Received: by mail-ua0-x22d.google.com with SMTP id v17-v6so1466638uak.6; Thu, 10 May 2018 07:41:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4iK+HABveb9nNaXsdKZLh2Cjw99ahRspyoJHZbaqumw=; b=N7LSDsreiPIShYRkHg/pJegkDe3ZfK5gE3qSNHkYi6F0oZ7U8vQVYYkBSziaXy7fnb THtqHSZWgfe9lebk7HtY+VrbI7Xe6XVFehLbtb5vv35lXQh3eBUyPM5KSdUpcw8AmE/B k9pepkeoVPP1OMNBLZLKaqZRZK0F++DQ/0j/7MiKpLXtGk+Cu/oX4DtNXE88P7/5xGBm nE4iHwgRnc9TFq5Tqbq8PEy5WHrGSdQlYn+EfEjLw02nsrPe/SNEPDsfXvk9BgWhJgpc RTVZQ8YXVb+C2VI3fCB1WpeKV8x8u/ZfNLHw2S8roid8LZ8YZL36vk+7TG6IYlVjAe2F XvxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4iK+HABveb9nNaXsdKZLh2Cjw99ahRspyoJHZbaqumw=; b=EAFzXdCq99l/BStgSszwi3WOL/TN55MBcm0lOqyypm8hGTCFfXyQF5IJAFnOOo0sYt ACwWp0lHc8VtyyjIMcbEaJilyEL+zNiJKWQnfWJ4teO38ONhBgMdje4TVta+yZLflo5H FpqK2miGG8wU/8MbeXiY0P64QH1K5tv9I4A2LAFQKR87XUoimSWeQM1ibLHBAKrXCU4a ihrQNsKqYYath/F6gZEmzL28lPGo+/kcbiUQWPIzl3/5M4zFTbNPaTFZ2+yRkNvumwiO 2+JrnlJur1nG81T9sM3f1DrDBdvu24EPjGXr5z0jnZ4d5aDrxjyjJarGhu9yPMiEiAJ8 zdjw== X-Gm-Message-State: ALKqPwdWr/SddgfQdrxcSikVTOBDxt/6LgaJDJJEoy0bzJG7pec7ytLU dipl5ydgSAUpm1ybiZPYGWwj9Qs7Y7a+HvEE2Ng= X-Google-Smtp-Source: AB8JxZrYxt15HU7pAXniT/sMlOz06vobyK4uM54hfgOs/ouEP4rHCL2x1zB+2gclJwOdawrKIPfVCzlvyoY8RSHKWzI= X-Received: by 2002:ab0:6008:: with SMTP id j8-v6mr1211432ual.179.1525963269206; Thu, 10 May 2018 07:41:09 -0700 (PDT) MIME-Version: 1.0 References: <4AC438CE-A49C-458E-A989-B145A4FBAA15@FreeBSD.org> In-Reply-To: <4AC438CE-A49C-458E-A989-B145A4FBAA15@FreeBSD.org> From: Rick Miller Date: Thu, 10 May 2018 14:40:58 +0000 Message-ID: Subject: Re: lint errors in stable/11 To: Dimitry Andric Cc: "freebsd-stable@freebsd.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 May 2018 14:41:10 -0000 On Thu, May 10, 2018 at 8:23 AM Dimitry Andric wrote: > On 10 May 2018, at 12:47, Rick Miller wrote: > > > > On Thu, May 10, 2018 at 6:35 AM Rick Miller wrote= : > ... > >> Performing a release build via release/release.sh in r331337 of > stable/11 > >> errors citing the lack of lint. It=E2=80=99s understood lint was remov= ed from > >> stable/11 so src.conf includes WITHOUT_LINT, but errors persist. As th= e > >> code review alludes to[1], lint is irrelevant here. It seems > WITHOUT_LINT > >> may not be the only thing I=E2=80=99m looking for. What is the best ap= proach for > >> mitigating these errors? > >> > >> > > Here=E2=80=99s the error w/o email munging: > > > > =3D=3D=3D> usr.bin/xlint/xlint (all) > > /data/dists/11.1.9.0-amd64-md/usr/src/contrib/apr/atomic/uni > > x/builtins.c:71:53: > > warning: passing 'const void *' to parameter of type 'volatile void *' > > discards > > qualifiers [-Wincompatible-pointer-types-discards-qualifiers] > > > > return (void*) __sync_val_compare_and_swap(mem, cmp, with); > > > > ^~~ > > > > 1 warning generated. > > > > =3D=3D=3D> usr.bin/xlint/llib (all) > > > > sh: lint: not found > > Are you building on a -CURRENT host? If so, see the previous mail > thread about this: > > > https://lists.freebsd.org/pipermail/freebsd-stable/2017-November/088092.h= tml > > and https://bugs.freebsd.org/223892. > > No, the build system is stable/11 r331337 building releng/11.1. The build system doesn=E2=80=99t include =E2=80=98lint=E2=80=99: # echo $PATH /sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/root/bin # which lint lint: Command not found. The mail thread and bug refer to building stable/11 on current where this case is building releng/11.1 on stable/11. They also do not appear to provide actionable information on mitigating errors though the code commit[1] suggests installing a lint will resolve. Ports doesn=E2=80=99t se= em to contain a suitable replacement however. Can lint still be installed on the build system from the stable/11 source? If so, how is that accomplished? Do WITH/WITHOUT_LINT have any impact here? The source has been built with WITH_LINT and WITHOUT_LINT to the same result except that xlint either builds or doesn=E2=80=99t depending on the option. This all seems to originate with llib=E2=80=99s dependency on lint as descr= ibed in the email thread. It is in building llib where the error occurs. [1] https://reviews.freebsd.org/D13799=EF=BB=BF -Rick --=20 Take care Rick Miller