From owner-svn-ports-head@FreeBSD.ORG Wed Apr 29 11:47:39 2015 Return-Path: Delivered-To: svn-ports-head@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 019157EF for ; Wed, 29 Apr 2015 11:47:38 +0000 (UTC) Received: from vfemail.net (ninezero.vfemail.net [96.30.253.190]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C31D813C2 for ; Wed, 29 Apr 2015 11:47:35 +0000 (UTC) Received: (qmail 6892 invoked by uid 89); 29 Apr 2015 11:47:35 -0000 Received: from localhost (HELO freequeue.vfemail.net) (127.0.0.1) by localhost with (DHE-RSA-AES256-SHA encrypted) SMTP; 29 Apr 2015 11:47:34 -0000 Received: (qmail 67693 invoked by uid 89); 28 Apr 2015 19:37:40 -0000 Received: by simscan 1.3.1 ppid: 67680, pid: 67687, t: 0.0069s scanners:none Received: from unknown (HELO smtp102-2.vfemail.net) (172.16.100.62) by FreeQueue with SMTP; 28 Apr 2015 19:37:40 -0000 Received: (qmail 22199 invoked by uid 89); 28 Apr 2015 19:37:40 -0000 Received: by simscan 1.4.0 ppid: 22182, pid: 22196, t: 0.9951s scanners:none Received: from unknown (HELO nil) (amJlaWNoQHZmZW1haWwubmV0@172.16.100.27) by 172.16.100.62 with ESMTPA; 28 Apr 2015 19:37:39 -0000 From: Jan Beich To: Bryan Drewery Cc: Lars Engels , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@FreeBSD.ORG, shadowbq@gmail.com Subject: Re: svn commit: r384872 - in head/security: . passivedns passivedns/files References: <201504272033.t3RKXcGl079169@svn.freebsd.org> <553FD751.6060408@FreeBSD.org> Date: Tue, 28 Apr 2015 21:37:29 +0200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2015 11:47:39 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable (resent due to MUA error) Bryan Drewery writes: > On 4/27/2015 3:33 PM, Lars Engels wrote: > >> +DISTVERSION=3D ${GH_TAG} > [...] >> +GH_TAG=3D a6c7e26 > > Actually this is not valid either. As soon as a new commit is done the > port may "go backwards". > Commit hashses are not valid versions. Dates are. git describe --tags output is no worse than appending svn revision to the nearest release. DISTFILES was already partially correct. $ pkg version -t 1.1.3 1.1.3-60 < > A PORTEPOCH bump will be needed as well after fixing this. Not really. bsd.port.mk assumes any letter as a pre-release suffix. # PORTVERSION=3Da6c7e26 $ pkg version -t a6c7e26 0 < # DISTVERSION=3Da6c7e26 $ pkg version -t a6.c7.e26 0 < > > For example: > > PORTVERSION=3D 20150428 Please, don't advise unprefixed dates! If one later wants to go back to a tag it'd require PORTEPOCH bump (documented in Porter's Handbook). $ pkg version -t 20150428 1.1.4 > # PORTEPOCH=3D1 $ pkg version -t 20150428 1.1.4,1 < Not to mention dates should correspond to the latest commit date, not an arbitrary packaging date. For a6c7e26 it'd be 20150115 (UTC). https://github.com/gamelinux/passivedns/commit/a6c7e26 > PORTEPOCH=3D 1 > GH_TAGNAME=3D a6c7e26 > > On updates just update the date and GH_TAGNAME. Index: security/passivedns/Makefile =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =2D-- security/passivedns/Makefile (revision 384934) +++ security/passivedns/Makefile (working copy) @@ -1,9 +1,8 @@ # $FreeBSD$ =20 PORTNAME=3D passivedns =2DDISTVERSION=3D ${GH_TAG} +DISTVERSION=3D 1.1.3-60 CATEGORIES=3D security =2DDISTFILES=3D gamelinux-passivedns-1.1.3-60-ga6c7e26.tar.gz =20 MAINTAINER=3D shadowbq@gmail.com COMMENT=3D Network sniffer that logs DNS replies for use in passive DNS se= tups @@ -14,11 +13,8 @@ LIB_DEPENDS=3D libldns.so:${PORTSDIR}/dns/ldns =20 USE_GITHUB=3D yes GH_ACCOUNT=3D gamelinux =2DGH_PROJECT=3D passivedns =2DGH_TAG=3D a6c7e26 +GH_TAGNAME=3D a6c7e26 =20 =2DWRKSRC=3D ${WRKDIR}/gamelinux-${PORTNAME}-${GH_TAG} =2D SUB_FILES=3D pkg-message =20 USES=3D autoreconf gmake libtool Index: security/passivedns/distinfo =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =2D-- security/passivedns/distinfo (revision 384934) +++ security/passivedns/distinfo (working copy) @@ -1,2 +1,2 @@ =2DSHA256 (gamelinux-passivedns-1.1.3-60-ga6c7e26.tar.gz) =3D efaff55f68330= 9a2cdc42a366ec9f7669cf7989939b7928517fc60f2f258ce51 =2DSIZE (gamelinux-passivedns-1.1.3-60-ga6c7e26.tar.gz) =3D 51312 +SHA256 (gamelinux-passivedns-1.1.3-60-a6c7e26_GH0.tar.gz) =3D efaff55f6833= 09a2cdc42a366ec9f7669cf7989939b7928517fc60f2f258ce51 +SIZE (gamelinux-passivedns-1.1.3-60-a6c7e26_GH0.tar.gz) =3D 51312 Index: security/passivedns/pkg-plist =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =2D-- security/passivedns/pkg-plist (revision 384934) +++ security/passivedns/pkg-plist (working copy) @@ -1,2 +1,2 @@ =2Dbin/passivedns +0;95;0cbin/passivedns @dir(root,wheel,750) /var/log/passivedns --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQF8BAEBCgBmBQJVP+F5XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3b/coIANZzAMeTEB0wW0yysjgEH/BT W7jZ7VCEisLYqzrc6u6eapzaZS6+tdNIYdUUFLxS37cHOQ8oMvtxt7qNdWaeJTi8 GwPWB9B3V+RRqonH7rYKZirediqZgXpfAdxagyUR7x2FN/5tIhRYoB23q2reNitz JYWc2vAbAKbGyuJ8LdK6Xma0bGVfnMjT3fJ4g1iDT8gF8UR/Pc0laEyvXRIKdRsw xW8TrnMAj/Dlh1X2MvfB/8iTjrBpKKLqiDsjcP3jZvVfGQvgLta/9q9M5BxnPG2O mN4iEmlYzyPinnt3sgm4l5sbKln9jcPNqaAWO3eimDMMtzKRoYNLf49QsIfYP04= =TeKF -----END PGP SIGNATURE----- --=-=-=--