From owner-svn-src-head@freebsd.org Sat Jun 10 17:15:54 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ADCFFBF2411; Sat, 10 Jun 2017 17:15:54 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 659DE802EC; Sat, 10 Jun 2017 17:15:53 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id JjzLdgNYLM9gtJjzMdAczI; Sat, 10 Jun 2017 11:15:53 -0600 X-Authority-Analysis: v=2.2 cv=a+JAzQaF c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=kj9zAlcOel0A:10 a=LWSFodeU3zMA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=rlky0nllBlnOgKZJO7AA:9 a=OOACZfwmZgXls7C0:21 a=e06E2zqhM-huLnB6:21 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id AD26E1AAC; Sat, 10 Jun 2017 10:15:51 -0700 (PDT) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id v5AHEajO026207; Sat, 10 Jun 2017 10:14:36 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201706101714.v5AHEajO026207@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org cc: Cy Schubert Subject: Re: svn commit: r319795 - head/contrib/ipfilter/tools In-Reply-To: Message from Cy Schubert of "Sat, 10 Jun 2017 17:05:14 -0000." <201706101705.v5AH5Eep078148@repo.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sat, 10 Jun 2017 10:14:36 -0700 X-CMAE-Envelope: MS4wfAiiSraoaQKK+y2lSrLUPgcdy1nSFZ7r1pA5+5XmDtL73ymU7mPGxEoRwxkwrAU5I+uOjV2F6dbeUIVquM14XBhBv+cFLC1foqOfjCPdu4oh35XMbSuR wRTOGLfBMovLWlYM4qoUcieiijfHufbo82y7eJcsSe/aGfZk/dFBrtPLQF8DKyxrP4xqdNJIERDkTvmNuAdwi9KHztSkxlkcF93UPpqhj2czOf7IXv8p7fXk QScOT4jrrtVXj9rO/YISbf6jAfVM9bZ8fp6iKMRcLV9pCT6H1T8NVQYgTCRGDYS1 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Jun 2017 17:15:54 -0000 In message <201706101705.v5AH5Eep078148@repo.freebsd.org>, Cy Schubert writes: > Author: cy > Date: Sat Jun 10 17:05:14 2017 > New Revision: 319795 > URL: https://svnweb.freebsd.org/changeset/base/319795 > > Log: > Disable the -O (output fields) option in poollist() (ippool -l) for > now. The option does not presently work. However, similar functions in > ipfstat (for state) and ipnat (for nat) do work and provide outputs that > can be easily parsed by shell scripts or subsequently loaded into CSV > files. The intention here is to return to this option to make it work. > I suspect the problem is in printpoolfields.c. > > Modified: > head/contrib/ipfilter/tools/ippool.c > > Modified: head/contrib/ipfilter/tools/ippool.c > ============================================================================= > = > --- head/contrib/ipfilter/tools/ippool.c Sat Jun 10 16:42:39 2017 > (r319794) > +++ head/contrib/ipfilter/tools/ippool.c Sat Jun 10 17:05:14 2017 > (r319795) > @@ -79,7 +79,7 @@ usage(prog) > fprintf(stderr, "\t-A [-dnv] [-m ] [-o ] [-S ] [-t ype>]\n"); > fprintf(stderr, "\t-f [-dnuv]\n"); > fprintf(stderr, "\t-F [-dv] [-o ] [-t ]\n"); > - fprintf(stderr, "\t-l [-dv] [-m ] [-t ] [-O ]\n"); > + fprintf(stderr, "\t-l [-dv] [-m ] [-t ]\n"); > fprintf(stderr, "\t-r [-dnv] [-m ] [-o ] [-t type] -i dr>[/netmask]\n"); > fprintf(stderr, "\t-R [-dnv] [-m ] [-o ] [-t ]\n"); > fprintf(stderr, "\t-s [-dtv] [-M ] [-N ]\n"); > @@ -687,9 +687,16 @@ poollist(argc, argv) > return -1; > } > break; > +#if 0 > case 'O' : > + /* XXX This option does not work. This function as */ > + /* XXX used by state and nat can be used to format */ > + /* XXX output especially useful for scripting. It */ > + /* XXX is left here with the intention of making */ > + /* XXX it work for the same purpose at some point. */ > pool_fields = parsefields(poolfields, optarg); > break; > +#endif > case 't' : > type = gettype(optarg, NULL); > if (type == IPLT_NONE) { > There is other higher priority breakage in ippool that needs to be addressed first before going down this rabbit hole. Addressing this now would delay addressing other general parsing issues and the problem in radix_ipf whereby only the first 32 bits of an IP address are compared to determine if an IP address can be added to a table, meaning that even though IPv6 is generally supported by most of ippool handling in the kernel, it is not effectively supported by because of this. So, disabling of this option for now until larger issues in ippool userspace and kernel can be addressed first. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.