From owner-freebsd-hackers@FreeBSD.ORG  Thu Apr  5 06:50:40 2007
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
X-Original-To: freebsd-hackers@freebsd.org
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 47D0116A401
	for <freebsd-hackers@freebsd.org>; Thu,  5 Apr 2007 06:50:40 +0000 (UTC)
	(envelope-from marcus@marcuscom.com)
Received: from creme-brulee.marcuscom.com (creme-brulee.marcuscom.com
	[24.172.16.118])
	by mx1.freebsd.org (Postfix) with ESMTP id 08C5A13C43E
	for <freebsd-hackers@freebsd.org>; Thu,  5 Apr 2007 06:50:39 +0000 (UTC)
	(envelope-from marcus@marcuscom.com)
Received: from [192.168.1.4] (shumai.marcuscom.com [192.168.1.4])
	by creme-brulee.marcuscom.com (8.13.8/8.13.8) with ESMTP id
	l356VH8C075162
	for <freebsd-hackers@freebsd.org>; Thu, 5 Apr 2007 02:31:17 -0400 (EDT)
	(envelope-from marcus@marcuscom.com)
From: Joe Marcus Clarke <marcus@marcuscom.com>
To: freebsd-hackers@freebsd.org
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-k00fuJWJgiqlU69TYR/u"
Organization: MarcusCom, Inc.
Date: Thu, 05 Apr 2007 02:30:55 -0400
Message-Id: <1175754655.67579.41.camel@shumai.marcuscom.com>
Mime-Version: 1.0
X-Mailer: Evolution 2.10.0 FreeBSD GNOME Team Port 
X-Mailman-Approved-At: Thu, 05 Apr 2007 11:24:59 +0000
Subject: Problem with test(1)
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Apr 2007 06:50:40 -0000


--=-k00fuJWJgiqlU69TYR/u
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

I noticed something weird with test(1) when I ran across a problem port
Makefile.  Our test(1) doesn't properly check to make sure there is an
operand argument to unary operators like -f.  For example:

test -f

Will print "TRUE" on FreeBSD.  On Solaris, it will die:

/usr/bin/test[8]: test: argument expected

I think this patch is correct in that it does fix the problem, and the
TEST.sh and TEST.csh regression scripts report the same results pre and
post-patch.  Comments?

http://www.marcuscom.com/downloads/text.c.diff

Joe

--=20
PGP Key : http://www.marcuscom.com/pgp.asc

--=-k00fuJWJgiqlU69TYR/u
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (FreeBSD)

iD8DBQBGFJecb2iPiv4Uz4cRAhGqAJoDKjCVYO7bCiQtkG5pC474HnAczQCgkedv
zlg6DX2CGLAS7I/zCBdNZUQ=
=Dj/L
-----END PGP SIGNATURE-----

--=-k00fuJWJgiqlU69TYR/u--