From owner-p4-projects@FreeBSD.ORG  Mon Jan 15 23:15:52 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id E5CF316A417; Mon, 15 Jan 2007 23:15:51 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id BF11F16A40F
	for <perforce@freebsd.org>; Mon, 15 Jan 2007 23:15:51 +0000 (UTC)
	(envelope-from piso@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
	by mx1.freebsd.org (Postfix) with ESMTP id B09A513C468
	for <perforce@freebsd.org>; Mon, 15 Jan 2007 23:15:51 +0000 (UTC)
	(envelope-from piso@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id l0FNFpP0037973
	for <perforce@freebsd.org>; Mon, 15 Jan 2007 23:15:51 GMT
	(envelope-from piso@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id l0FNFpsm037970
	for perforce@freebsd.org; Mon, 15 Jan 2007 23:15:51 GMT
	(envelope-from piso@freebsd.org)
Date: Mon, 15 Jan 2007 23:15:51 GMT
Message-Id: <200701152315.l0FNFpsm037970@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	piso@freebsd.org using -f
From: Paolo Pisati <piso@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 112959 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Jan 2007 23:15:52 -0000

http://perforce.freebsd.org/chv.cgi?CH=112959

Change 112959 by piso@piso_newluxor on 2007/01/15 23:15:43

	Looks like we don't need intr_table_lock while scanning
	through interrupt_sources[].
	While here, do some spacing and indentation according
	to style. 

Affected files ...

.. //depot/projects/soc2006/intr_filter/amd64/amd64/intr_machdep.c#21 edit

Differences ...

==== //depot/projects/soc2006/intr_filter/amd64/amd64/intr_machdep.c#21 (text+ko) ====

@@ -227,10 +227,13 @@
 walk_intr_src(void) {
 	struct intsrc *isrc;
 	static int i = 0;
+	int j;
 
-	for (; i<NUM_IO_INTS; ) {
-		int j = i++;
+	for (; i < NUM_IO_INTS;) {
+		j = i++;
+		mtx_lock_spin(&intr_table_lock);
 		isrc = interrupt_sources[j];
+		mtx_unlock_spin(&intr_table_lock);	
 		if (isrc != NULL && isrc->is_event != NULL)
 			return (isrc->is_event);
 	}
@@ -242,9 +245,8 @@
 intr_callout_reset(void)
 {
 
-	mtx_lock_spin(&intr_table_lock);
-	callout_reset(&stray_callout_handle, hz, &stray_detection, &walk_intr_src);
-	mtx_unlock_spin(&intr_table_lock);	
+	callout_reset(&stray_callout_handle, hz, &stray_detection, 
+	    &walk_intr_src);
 }
 
 void
@@ -397,7 +399,7 @@
 	intrcnt_index = 1;
 	STAILQ_INIT(&pics);
 	mtx_init(&intr_table_lock, "intr table", NULL, MTX_SPIN);
-	callout_init_mtx(&stray_callout_handle, &intr_table_lock, 0);
+	callout_init(&stray_callout_handle, 1);
 }
 SYSINIT(intr_init, SI_SUB_INTR, SI_ORDER_FIRST, intr_init, NULL)