From owner-svn-src-head@freebsd.org Wed May 9 21:12:27 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E9235FCC80C; Wed, 9 May 2018 21:12:26 +0000 (UTC) (envelope-from oshogbo.vx@gmail.com) Received: from mail-lf0-x243.google.com (mail-lf0-x243.google.com [IPv6:2a00:1450:4010:c07::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5CE277002C; Wed, 9 May 2018 21:12:26 +0000 (UTC) (envelope-from oshogbo.vx@gmail.com) Received: by mail-lf0-x243.google.com with SMTP id x7-v6so17976425lff.13; Wed, 09 May 2018 14:12:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Bv/GWVnleopESpbDF1LmWArTItN82hdldpYv0R0sZpE=; b=I728j5SQwHTdrfvfpW7H7hFFF903yh90863QrvsozFzuDN0dS16xa6QyrBMIYR0u9O LpxgRuN2QAqdy3fIg3M5xq7vbziPpKC1tDETbZunjYo90YQQJdLu8V+c06Ky3xWkKQ5g +604V87zHRYPDGfYq8DsR0ckkOzwoT/QbpstSDNghG7xRbyj6H8Pf+U1PHQ22AN1c/vG sw2Dx/iV2TR0HXKwV/5nM4LhtgbpKDrA3Eo/Zv++Z36JEMDKLLkAI/HYirm8MHvNulp+ +ChChjOFpXxar/5wkrAypRzfyvC3I5y/pqi3LNeNfA09M886pDE0ucOGXakf8Xse8b3S h4EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=Bv/GWVnleopESpbDF1LmWArTItN82hdldpYv0R0sZpE=; b=b59LMQy9BM4xsm3DkI3Dk8MnAKQLiydzi22SzNJj+hq5yEJDQ/8WmzxOAV+CO6nk9u W4p5V8bJhSjZYL8eaPSzYcH38JUwja+v2sTd6/2NfwuenTBXOaKpT3LOG8uuVw9gzh/H Z6iDWdB3RgB/0UG4FDyTbEJbrLnTf/eqnSj8Thg2FUszpuTBdJw+V1tBbuzrdOqarJ+U g2Nis6czAeJwZ7rRzZ1+ncQlGoXMyhHSFl3IriTVZUHKgZHEpNS01bLvEru6Fqur5gvP TjcKY1b0urwJBNaK61KcOFIl611AV9iugr4jRogdtl6Y3jaMKBcUZLyulkb/J1RPrkBz /1BQ== X-Gm-Message-State: ALQs6tDsbSfVCNjrmsoEEFhy32ZB6oMdCrZkBPd5JOEBEvO0gN1t7H4U vbKwGqthpMstFPyesvubnllPmXBc X-Google-Smtp-Source: AB8JxZpw1epa65qDZJVjFoig+KNQfY/2yHvwqe3n6198NOOuIlU2HKdNcgLY+Lo7sk7Zc7RbUxNxyg== X-Received: by 2002:a19:930f:: with SMTP id v15-v6mr13825668lfd.83.1525900344598; Wed, 09 May 2018 14:12:24 -0700 (PDT) Received: from x-wing (87-206-170-77.dynamic.chello.pl. [87.206.170.77]) by smtp.gmail.com with ESMTPSA id b5-v6sm4466920ljj.73.2018.05.09.14.12.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 May 2018 14:12:23 -0700 (PDT) Sender: Mariusz Zaborski Date: Thu, 10 May 2018 00:13:12 +0200 From: Mariusz Zaborski To: Ian Lepore Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r333438 - head/sbin/geom/class/eli Message-ID: <20180509221312.GA27592@x-wing> References: <201805092051.w49KpGZm079239@repo.freebsd.org> <1525899943.35372.42.camel@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5vNYLRcllDrimb99" Content-Disposition: inline In-Reply-To: <1525899943.35372.42.camel@freebsd.org> User-Agent: Mutt/1.9.5 (2018-04-13) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 21:12:27 -0000 --5vNYLRcllDrimb99 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 09, 2018 at 03:05:43PM -0600, Ian Lepore wrote: > On Wed, 2018-05-09 at 20:51 +0000, Mariusz Zaborski wrote: > > Author: oshogbo > > Date: Wed May=A0=A09 20:51:16 2018 > > New Revision: 333438 > > URL: https://svnweb.freebsd.org/changeset/base/333438 > >=20 > > Log: > > =A0 Change option dry-run from 'n' to 'C' in geli attach command. > > =A0=A0 > > =A0 'n' is used in other commands to define the key index. > > =A0 We should be consistent with that. > > =A0 'C' option is used by patch(1) to perform dryrun so lets use that. >=20 > This seems like a dangerous change. Today I am begining to write new > product image creation scripts that involve geli, and I'm going to do > so under the assumption that the commands and arguments are not going > to suddenly change their meaning on some future OS update. >=20 > Hopefully the new meaning of -n implies an argument which is validated > as being either 0 or 1, so that any existing scripts that contain -n to > mean "dry run" will very likely fail the validation and not silently > misbehave. >=20 > At the very least, it seems like an entry in UPDATING is required. Oliver, Ian - thank you for noticing this. I wasn't sure if we need to add UPDATING or release notes because I added '= n' option couple weeks ago and wasn't integrated to any stable/release branch. Considering that should we still update UPDATING? Thanks, --=20 Mariusz Zaborski oshogbo//vx | http://oshogbo.vexillium.org FreeBSD commiter | https://freebsd.org Software developer | http://wheelsystems.com If it's not broken, let's fix it till it is!!1 --5vNYLRcllDrimb99 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkD1x0xkJXVVY1Gwf38KEGuLGxWQFAlrzcmoACgkQ38KEGuLG xWSl/w/+KmElVSTFKE1NpcRlG2ozz/TbzMl0s6OGb2JpOMEHVT+tsQUsdJFA+wgD OQOHhwHgKkp/4IosU3HdwfcvuqjuHDcfQLLvl0bue0HwdjiRc1BvNBFyx9AVgCzr pVv/W/Ymp6PjuyT7lKMpX4UQ7RZV3BCVPq0nGnzkJ/sf5VPnaQId/S3IupaaRpTg juyJ2vgdT/hG8+jRlpk2YeBXsiOBf2dQo8iQEn7EjG36RSQQq9pSA9SV3Q3H74b+ or/Td9b9IuWzBLZdmb9DVImwrI20ICV9SA4QvEmqtD2dct+eaiIlESn26Pj2Q+3Y KK2BhZxupY2Oq6p2wRV2SBvtDS0iYKH76EJHzehFq5ZfL0p2lKCs5bDO5i4BMsZb zj4lFz2uC1MwUNPwAVdv+cGTB/vKUUrttK4pWMdFH9394dOhoTaI+r89QrU2GINg HUt3Ld+45beR1xjYsVmil+On7qN/Is22QiWQMdvZh0pddRTcvX4oXQ+bXGLnWNdD RVSiYK2s6pzAYTxz//8pmxImg+ACJ1tZfhB6gIYrrLfGygwjG0Ey2Z2F4IiDyhnY 2Dco6Dhq3zbiIg5Ds3VSCUA3XbBobyzfKAQSQOkDzJbpOXd4qresaLQFfNIUvuvZ UJLMYo9v3pEvdbDmMM4YpCVFfEkKYNDpSRGzycmNoBWkMWTFB1I= =fK5p -----END PGP SIGNATURE----- --5vNYLRcllDrimb99--