From owner-freebsd-current@FreeBSD.ORG Mon Jul 11 21:14:53 2011 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4CD69106564A for ; Mon, 11 Jul 2011 21:14:53 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 87B788FC1C for ; Mon, 11 Jul 2011 21:14:52 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id AAA28847; Tue, 12 Jul 2011 00:14:49 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1QgNoX-000N34-AR; Tue, 12 Jul 2011 00:14:49 +0300 Message-ID: <4E1B67C7.8040402@FreeBSD.org> Date: Tue, 12 Jul 2011 00:14:47 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:5.0) Gecko/20110706 Thunderbird/5.0 MIME-Version: 1.0 To: Arnaud Lacombe References: <4E1421D9.7080808@zedat.fu-berlin.de> <4E147F54.40908@zedat.fu-berlin.de> <20110706162811.GA68436@troutmask.apl.washington.edu> <20110706193636.GA69550@troutmask.apl.washington.edu> <4E14CCE5.4050906@zedat.fu-berlin.de> <20110707015151.GB71966@troutmask.apl.washington.edu> In-Reply-To: X-Enigmail-Version: 1.2pre Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: FreeBSD Current Subject: Re: Heavy I/O blocks FreeBSD box for several seconds X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jul 2011 21:14:53 -0000 on 11/07/2011 23:33 Arnaud Lacombe said the following: > For the record, I would like to see enforced public review for _every_ > patch *before* it is checked in, as a strong rule. gcc system is > particularly interesting. But it is not likely to happen in FreeBSD > where FreeBSD committers are clearly more free than other at > checking-in un-publicly-reviewed stuff (especially _bad_ stuff). > > This would of course apply even to long-time committers, no matter how > it hurt their ego (which I definitively do not care about). Have you just volunteered to review all of the patches that I would like to commit? And are you prepared to take responsibility for quality of your reviews? I am sure that other developers will gladly accept your offer too. -- Andriy Gapon