From owner-cvs-all Sun Dec 10 18: 2:15 2000 From owner-cvs-all@FreeBSD.ORG Sun Dec 10 18:02:12 2000 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from athserv.otenet.gr (athserv.otenet.gr [195.170.0.1]) by hub.freebsd.org (Postfix) with ESMTP id 5462A37B698; Sun, 10 Dec 2000 18:02:10 -0800 (PST) Received: from hades.hell.gr (patr530-b076.otenet.gr [195.167.121.204]) by athserv.otenet.gr (8.10.1/8.10.1) with ESMTP id eBB1wqk14443; Mon, 11 Dec 2000 03:58:53 +0200 (EET) Received: (from charon@localhost) by hades.hell.gr (8.11.1/8.11.1) id eBB207M05364; Mon, 11 Dec 2000 04:00:07 +0200 (EET) Date: Mon, 11 Dec 2000 04:00:07 +0200 From: Giorgos Keramidas To: Brian Somers Cc: Dag-Erling Smorgrav , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/etc crontab Message-ID: <20001211040007.A5252@hades.hell.gr> References: <200012110116.eBB1GGV06691@hak.lan.Awfulhak.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.4i In-Reply-To: <200012110116.eBB1GGV06691@hak.lan.Awfulhak.org>; from brian@Awfulhak.org on Mon, Dec 11, 2000 at 01:16:16AM +0000 X-PGP-Fingerprint: 3A 75 52 EB F1 58 56 0D - C5 B8 21 B6 1B 5E 4A C2 X-URL: http://students.ceid.upatras.gr/~keramida/index.html Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Mon, Dec 11, 2000 at 01:16:16AM +0000, Brian Somers wrote: > > des 2000/12/10 04:54:35 PST > > ... > > Revision Changes Path > > 1.25 +3 -3 src/etc/crontab > > I think this should be backed out in favour of either Giorgos' > solution (with a comment maybe saying what's going on) or the lockf > solution. I tested my proposed patch this night, by playing around with the day of the month that monthly runs and day of week that weekly starts, and it seems to work. I changed the scripts in /etc/periodic/{daily,weekly,monthly} to a set of scripts that simply logged the time that the scripts started in syslog. Then by modifying /etc/crontab under cron's feet, I tricked it to run these scripts with numbers that checked all fours cases listed in crontab. I would really appreciate it if at least *one* other person did some testing too, though. I'd hate to see -current broken because I made some silly assumption about cron and messed with crontab badly. If anyone asks I can send a tarball with my modified /etc/periodic directory, and the four crontabs I used to test each case. But repeating my tests will not provide with any extra testing. I'd prefer it if someone did their own set of tests. The only problem I can think of so far with using it, is when the total time that it takes for all three scripts to run (on the first day of a month, which is the 6th day of a week too) is larger than 24 hours, the next day's daily script might fire up before the last night's `periodic monthly' invocation has finished. On a side-note, I think we will eventually have to merge both solutions, and have lockf integrated to the set of crontab entries I was trying to come up with. I will have to reread through the thread with the lockf thing, and see if I can write something towards this direction. In the mean time, we can choose either one of these solutions. Whichever your taste seems to prefer :) - giorgos To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message