From owner-freebsd-sysinstall@FreeBSD.ORG  Tue Jul 13 14:50:05 2010
Return-Path: <owner-freebsd-sysinstall@FreeBSD.ORG>
Delivered-To: freebsd-sysinstall@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 438FC106566C
	for <freebsd-sysinstall@hub.freebsd.org>;
	Tue, 13 Jul 2010 14:50:05 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 197F88FC1D
	for <freebsd-sysinstall@hub.freebsd.org>;
	Tue, 13 Jul 2010 14:50:05 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o6DEo4h4012868
	for <freebsd-sysinstall@freefall.freebsd.org>;
	Tue, 13 Jul 2010 14:50:04 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o6DEo4pA012867;
	Tue, 13 Jul 2010 14:50:04 GMT (envelope-from gnats)
Date: Tue, 13 Jul 2010 14:50:04 GMT
Message-Id: <201007131450.o6DEo4pA012867@freefall.freebsd.org>
To: freebsd-sysinstall@FreeBSD.org
From: Garrett Cooper <yanegomi@gmail.com>
Cc: 
Subject: Re: bin/97108: sysinstall(8): write failure on transfer (wrote -1 
	bytes of 1425408 bytes)
X-BeenThere: freebsd-sysinstall@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Garrett Cooper <yanegomi@gmail.com>
List-Id: Sysinstall Work <freebsd-sysinstall.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-sysinstall>, 
	<mailto:freebsd-sysinstall-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-sysinstall>
List-Post: <mailto:freebsd-sysinstall@freebsd.org>
List-Help: <mailto:freebsd-sysinstall-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-sysinstall>, 
	<mailto:freebsd-sysinstall-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Jul 2010 14:50:05 -0000

The following reply was made to PR bin/97108; it has been noted by GNATS.

From: Garrett Cooper <yanegomi@gmail.com>
To: bug-followup@FreeBSD.org, juan.fco.rodriguez@gmail.com
Cc:  
Subject: Re: bin/97108: sysinstall(8): write failure on transfer (wrote -1 
	bytes of 1425408 bytes)
Date: Tue, 13 Jul 2010 07:42:16 -0700

 It might help if we actually captured the error and displayed it...
 Thanks,
 -Garrett
 
 Index: dist.c
 ===================================================================
 --- dist.c	(revision 206173)
 +++ dist.c	(working copy)
 @@ -40,7 +40,9 @@
  #include <sys/time.h>
  #include <sys/uio.h>
  #include <ctype.h>
 +#include <errno.h>
  #include <signal.h>
 +#include <string.h>
  #include <libutil.h>
 
  unsigned int Dists;
 @@ -658,6 +660,7 @@
  	    /* No substitution necessary */
  	    retval = write(fd2, buf, realsize);
  	    if (retval != realsize) {
 +		msgDebug("Write failure on transfer: %s", strerror(errno));
  		fclose(fp);
  		dialog_clear_norefresh();
  		msgConfirm("Write failure on transfer! (wrote %d bytes of %d
 bytes)", retval, realsize);
 @@ -669,6 +672,7 @@
  		if ((buf[j] != 0x0d) || (j == total - 1) || (buf[j + 1] != 0x0a)) {
  		    retval = write(fd2, buf + j, 1);
  		    if (retval != 1) {
 +			msgDebug("Write failure on transfer: %s", strerror(errno));
  			fclose(fp);
  			dialog_clear_norefresh();
  			msgConfirm("Write failure on transfer! (wrote %d bytes of %d
 bytes)", j, chunksize);