Date: Mon, 11 Dec 2000 04:00:07 +0200 From: Giorgos Keramidas <keramida@ceid.upatras.gr> To: Brian Somers <brian@Awfulhak.org> Cc: Dag-Erling Smorgrav <des@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/etc crontab Message-ID: <20001211040007.A5252@hades.hell.gr> In-Reply-To: <200012110116.eBB1GGV06691@hak.lan.Awfulhak.org>; from brian@Awfulhak.org on Mon, Dec 11, 2000 at 01:16:16AM %2B0000 References: <des@FreeBSD.org> <200012110116.eBB1GGV06691@hak.lan.Awfulhak.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Dec 11, 2000 at 01:16:16AM +0000, Brian Somers wrote:
> > des 2000/12/10 04:54:35 PST
> >
...
> > Revision Changes Path
> > 1.25 +3 -3 src/etc/crontab
>
> I think this should be backed out in favour of either Giorgos'
> solution (with a comment maybe saying what's going on) or the lockf
> solution.
I tested my proposed patch this night, by playing around with the day of the
month that monthly runs and day of week that weekly starts, and it seems to
work.
I changed the scripts in /etc/periodic/{daily,weekly,monthly} to a set of
scripts that simply logged the time that the scripts started in syslog. Then
by modifying /etc/crontab under cron's feet, I tricked it to run these
scripts with numbers that checked all fours cases listed in crontab.
I would really appreciate it if at least *one* other person did some testing
too, though. I'd hate to see -current broken because I made some silly
assumption about cron and messed with crontab badly. If anyone asks I can
send a tarball with my modified /etc/periodic directory, and the four
crontabs I used to test each case. But repeating my tests will not provide
with any extra testing. I'd prefer it if someone did their own set of tests.
The only problem I can think of so far with using it, is when the total time
that it takes for all three scripts to run (on the first day of a month,
which is the 6th day of a week too) is larger than 24 hours, the next day's
daily script might fire up before the last night's `periodic monthly'
invocation has finished.
On a side-note, I think we will eventually have to merge both solutions, and
have lockf integrated to the set of crontab entries I was trying to come up
with. I will have to reread through the thread with the lockf thing, and see
if I can write something towards this direction. In the mean time, we can
choose either one of these solutions. Whichever your taste seems to prefer :)
- giorgos
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20001211040007.A5252>