From owner-cvs-all Wed Sep 5 17:41: 5 2001 Delivered-To: cvs-all@freebsd.org Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.80]) by hub.freebsd.org (Postfix) with ESMTP id 33A0437B406; Wed, 5 Sep 2001 17:40:56 -0700 (PDT) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id CC2696AD02; Thu, 6 Sep 2001 10:11:22 +0930 (CST) Date: Thu, 6 Sep 2001 10:11:22 +0930 From: Greg Lehey To: David O'Brien Cc: Bruce Evans , Garrett Wollman , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/include/arpa tftp.h Message-ID: <20010906101122.O4447@wantadilla.lemis.com> References: <20010904185643.A78975@dragon.nuxi.com> <20010905203608.K22645-100000@alphplex.bde.org> <20010905084549.A95963@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010905084549.A95963@dragon.nuxi.com>; from obrien@FreeBSD.org on Wed, Sep 05, 2001 at 08:45:49AM -0700 Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 6B 7B C3 8C 61 CD 54 AF 13 24 52 F8 6D A4 95 EF Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wednesday, 5 September 2001 at 8:45:49 -0700, David O'Brien wrote: > On Wed, Sep 05, 2001 at 08:39:34PM +1000, Bruce Evans wrote: >>>>> Log: >>>>> style(9) the structure definitions. >>>> Was this *really* necessary? >>>> I thought we had a policy against doing broad sweeps of >>>> non-substantive changes like this. >>> >>> Yes it was -- we were so confused (partically do to your commit to >>> style.9) that one could not figure out what was right. Now enough of the >>> key places to look for style guidlines have been fixed. I don't plan on >>> sweaping any more of the tree to just fix this. >> >> The existence of both in old code means that they were both right. > > The CSRG people can make mistakes too -- just like we do. A lot of our current style is based on mistakes. >> "struct\t.*{" does seem to be the least normal form although it is used >> in the oldest code (proc.h...), but you shouldn't have changed it while >> we are still discussing this. > > What more was there to discuss? > > This issue is one that is pretty easy to decide based on facts. When > there is a 3:1 ratio of to in our own code (and as you > pointed out most of those were due to makesyscalls.sh. (the ratio > was higher in the CSRG code). Wouldn't it be nice if our algorithms were as pretty as our "style"? Greg -- See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message