From owner-cvs-all@FreeBSD.ORG Fri Sep 12 06:39:24 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0858B16A4BF for ; Fri, 12 Sep 2003 06:39:24 -0700 (PDT) Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by mx1.FreeBSD.org (Postfix) with SMTP id 518E543FDF for ; Fri, 12 Sep 2003 06:39:21 -0700 (PDT) (envelope-from tmoestl@gmx.net) Received: (qmail 32182 invoked by uid 65534); 12 Sep 2003 13:39:20 -0000 Received: from p508E755B.dip.t-dialin.net (EHLO timesink.dyndns.org) (80.142.117.91) by mail.gmx.net (mp004) with SMTP; 12 Sep 2003 15:39:20 +0200 Received: by galatea (Postfix, from userid 1001) id BE23FCB; Fri, 12 Sep 2003 15:40:08 +0200 (CEST) Date: Fri, 12 Sep 2003 15:40:08 +0200 From: Thomas Moestl To: Poul-Henning Kamp Message-ID: <20030912134008.GA680@timesink.dyndns.org> Mail-Followup-To: Poul-Henning Kamp , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <20030912013930.GB691@timesink.dyndns.org> <1212.1063336022@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1212.1063336022@critter.freebsd.dk> User-Agent: Mutt/1.4.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/cam/scsi scsi_cd.c src/sys/dev/ata atapi-cd.c atapi-cd.h src/sys/isa fd.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Sep 2003 13:39:24 -0000 On Fri, 2003/09/12 at 05:07:02 +0200, Poul-Henning Kamp wrote: > In message <20030912013930.GB691@timesink.dyndns.org>, Thomas Moestl writes: > >On Fri, 2003/09/12 at 02:10:13 +0200, Poul-Henning Kamp wrote: > >> In message <20030911235214.GA691@timesink.dyndns.org>, Thomas Moestl writes: > >> > >> >The cloning handlers in the CD-ROM drivers used to be required to > >> >mount root from CD-ROM, which is e.g. required for the bootable > >> >sparc64 distribution disks. Have things changed so that they are no > >> >longer needed while I wasn't watching, or does this change break that > >> >case? > >> > >> Wouldn't that just be a matter of fixing the '/' line in /etc/fstab ? > > > >I don't think so. The cloning handler is used exclusively to determine > >rootdev, so devices which do not use disk_create() and thus do not get > > s/disk_create/disk_create or make_dev/ > > Which means that they are all covered. Hmmm, it doesn't seem to work though (and I can't seem to find any code which would make_dev() handle that; did you maybe forget to commit that change?): OK boot -a nothing to autoload yet. jumping to kernel entry at 0xc0038000. Copyright (c) 1992-2003 The FreeBSD Project. Copyright (c) 1979, 1980, 1983, 1986, 1988, 1989, 1991, 1992, 1993, 1994 The Regents of the University of California. All rights reserved. FreeBSD 5.1-CURRENT #4: Fri Sep 12 14:43:56 CEST 2003 [...] acd0: CDRW at ata2-slave PIO4 GEOM: create disk ad1 dp=0xfffff80000db76c0 ad1: 39266MB [79780/16/63] at ata3-master UDMA66 Manual root filesystem specification: : Mount using filesystem eg. ufs:/dev/da0a ? List valid disk boot devices Abort manual input mountroot> cd9660:acd0 Mounting root from cd9660:acd0 setrootbyname failed iso_mountroot: can't find rootvp Root mount failed: 6 However, if I reenable the atapi-cd clone code: Manual root filesystem specification: : Mount using filesystem eg. ufs:/dev/da0a ? List valid disk boot devices Abort manual input mountroot> cd9660:acd0 Mounting root from cd9660:acd0 cd9660: RockRidge Extension It seems that I was wrong in claiming that we need root-mounting ability for sparc64 releases though (it was only needed for the first bootable CD-ROMs before we started to use the standard release framework, which has the root file system in a bootmfs), so this breakage would be less critical than I initially thought. - Thomas -- Thomas Moestl http://www.tu-bs.de/~y0015675/ http://people.FreeBSD.org/~tmm/ PGP fingerprint: 1C97 A604 2BD0 E492 51D0 9C0F 1FE6 4F1D 419C 776C