From owner-freebsd-current  Tue Aug  1  3:27:24 2000
Delivered-To: freebsd-current@freebsd.org
Received: from smtp.email.msn.com (cpimssmtpu03.email.msn.com [207.46.181.19])
	by hub.freebsd.org (Postfix) with ESMTP id 5AA6C37B84E
	for <freebsd-current@freebsd.org>; Tue,  1 Aug 2000 03:27:21 -0700 (PDT)
	(envelope-from bonk1138@msn.com)
Received: from lando - 63.15.5.230 by email.msn.com with Microsoft SMTPSVC;
	 Tue, 1 Aug 2000 03:26:49 -0700
From: "James Johnson" <bonk1138@msn.com>
To: <freebsd-current@freebsd.org>
Subject: netinet compile broken
Date: Tue, 1 Aug 2000 03:25:35 -0700
Message-ID: <KJEDKFEKMMFFMPFPBLJHEEEJCHAA.bonk1138@msn.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3 (Normal)
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook IMO, Build 9.0.2416 (9.0.2911.0)
X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4133.2400
Importance: Normal
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

	sys/netinet/ip_fil.c appears to be busted. Trying to recompile kernel
modules breaks as follows:

===> ipfilter
<SNIP>

cc -O -pipe -DIPFILTER=1 -DIPFILTER_LKM -DIPFILTER_LOG  -D_KERNEL -Wall -Wre
dundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wp
ointer-arith -Winline -Wcast-qual  -fformat-extensions -ansi -DKLD_MODULE -n
ostdinc -I-  -I. -I@ -I@/../include  -mpreferred-stack-boundary=2 -c
/usr/src/sys/modules/ipfilter/../../netinet/ip_fil.c
/usr/src/sys/modules/ipfilter/../../netinet/ip_fil.c: In function
`iplattach':
/usr/src/sys/modules/ipfilter/../../netinet/ip_fil.c:272: too few arguments
to function `pfil_add_hook'
/usr/src/sys/modules/ipfilter/../../netinet/ip_fil.c: In function
`ipldetach':
/usr/src/sys/modules/ipfilter/../../netinet/ip_fil.c:384: too few arguments
to function `pfil_remove_hook'
*** Error code 1

Looks like two else statements were commented out. This simple diff fixes it

--- ip_fil.c	Tue Aug  1 00:04:24 2000
+++ ip_fil.bak	Tue Aug  1 03:18:08 2000
@@ -268,7 +268,7 @@
 		return error;
 #   endif
 	}
-#  else
+  else
 	pfil_add_hook((void *)fr_check, PFIL_IN|PFIL_OUT);
 #  endif
 #  ifdef USE_INET6
@@ -380,7 +380,7 @@
 				 &inetsw[ip_protox[IPPROTO_IP]].pr_pfh);
 	if (error)
 		return error;
-#  else
+	  else
 	pfil_remove_hook((void *)fr_check, PFIL_IN|PFIL_OUT);
 #  endif
 #  ifdef USE_INET6





To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message