Date: Thu, 22 Oct 2020 19:55:33 -0600 From: Alan Somers <asomers@freebsd.org> To: Rick Macklem <rmacklem@uoguelph.ca> Cc: freebsd-fs <freebsd-fs@freebsd.org> Subject: Re: Always-0 NFS statistics Message-ID: <CAOtMX2j7fNYNwLVM9Q8GEzD4Om6uzX2XKNmQu%2Bdz22CPFyATbw@mail.gmail.com> In-Reply-To: <YTBPR01MB396692E2EC66728FBB692231DD1A0@YTBPR01MB3966.CANPRD01.PROD.OUTLOOK.COM> References: <CAOtMX2jW_3dg6=EiM=xJNs5F5EYveaE4ShGZFAXcFNbxJuoRMw@mail.gmail.com> <YTBPR01MB396692E2EC66728FBB692231DD1A0@YTBPR01MB3966.CANPRD01.PROD.OUTLOOK.COM>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Oct 22, 2020 at 7:46 PM Rick Macklem <rmacklem@uoguelph.ca> wrote: > Alan Somers wrote: > >It looks to me like three of the server statistics published by nfsstat > are > >always 0. At least, cscope can't find any location in the kernel that > sets > >these variables. Are they legitimately always zero in FreeBSD's > >implementation of NFS, or are they reserved for future features, or is > this > >a mistake? The stats are: > > > >nfsstat's name kernel name > >Retfailed srv_errs > >Faults srvrpc_errs > >Idem srvcache_idemdonehits > I believe these are left over from when the code was originally written > for OpenBSD2.6, which did not have a separate kernel RPC, where the > NFS code did the RPC calls. > > I suppose they should have been deleted from the FreeBSD port once > it was incorporated into FreeBSD using the kernel RPC, but they were > not. > > Revising the nfsstats structure yet again is a bother. > I suppose you could modify nfsstats.c so that it never displays these > fields. I doubt that would be considered a POLA violation. > > rick > Yep, removing them from nfsstat sounds like the right thing to do given that they'll never be used again. -Alan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOtMX2j7fNYNwLVM9Q8GEzD4Om6uzX2XKNmQu%2Bdz22CPFyATbw>