From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Oct 31 09:40:33 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 07B9116A4CE for ; Sun, 31 Oct 2004 09:40:33 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id C815443D2D for ; Sun, 31 Oct 2004 09:40:32 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i9V9eWYW027599 for ; Sun, 31 Oct 2004 09:40:32 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i9V9eWwr027598; Sun, 31 Oct 2004 09:40:32 GMT (envelope-from gnats) Resent-Date: Sun, 31 Oct 2004 09:40:32 GMT Resent-Message-Id: <200410310940.i9V9eWwr027598@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Helge Oldach Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2E08A16A4CE for ; Sun, 31 Oct 2004 09:32:37 +0000 (GMT) Received: from sep.oldach.net (sep.oldach.net [194.180.25.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id E9E6143D2D for ; Sun, 31 Oct 2004 09:32:35 +0000 (GMT) (envelope-from hmo@sep.oldach.net) Received: from sep.oldach.net (localhost [127.0.0.1])i9V9WBbG070305 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=NO); Sun, 31 Oct 2004 10:32:14 +0100 (CET) (envelope-from hmo@sep.oldach.net) Received: (from hmo@localhost) by sep.oldach.net (8.13.1/8.13.1/Submit) id i9V9WAP3070304; Sun, 31 Oct 2004 10:32:10 +0100 (CET) (envelope-from hmo) Message-Id: <200410310932.i9V9WAP3070304@sep.oldach.net> Date: Sun, 31 Oct 2004 10:32:10 +0100 (CET) From: Helge Oldach To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 cc: qpopper-patches@qualcomm.com Subject: ports/73336: ports/qpopper X-UIDL handling not in line with documentation X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Helge Oldach List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 09:40:33 -0000 >Number: 73336 >Category: ports >Synopsis: ports/qpopper X-UIDL handling not in line with documentation >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Oct 31 09:40:30 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Helge Oldach >Release: FreeBSD 4.10-STABLE i386 >Organization: >Environment: System: FreeBSD localhost 4.10-STABLE FreeBSD 4.10-STABLE #2000: Sun Oct 24 13:07:42 CEST 2004 root@:/usr/obj/usr/src/sys/GENERIC i386 >Description: According to the documentation, the update-status-headers configuration option should disable both writing of "Status:" and "X-UIDL:" headers. But only the first happens to be the case. "X-UIDL:" headers are written to the mail store regardless of this setting. The patch below fixes this behaviour. >How-To-Repeat: >Fix: --- popper/pop_updt.c.ORIG Thu Jan 2 03:39:03 2003 +++ popper/pop_updt.c Sun Oct 31 10:09:30 2004 @@ -531,11 +531,13 @@ if ( fputs ( buffer, md ) == EOF ) break; - sprintf ( buffer, "X-UIDL: %s", mp->uidl_str ); - if ( fputs ( buffer, md ) == EOF ) - break; - length += strlen ( buffer ) + 1; /* for CRLF */ - lines ++; + if ( p->bUpdate_status_hdrs ) { + sprintf ( buffer, "X-UIDL: %s", mp->uidl_str ); + if ( fputs ( buffer, md ) == EOF ) + break; + length += strlen ( buffer ) + 1; /* for CRLF */ + lines ++; + } for ( status_written = 0, inheader = 1; fgets ( buffer, MAXMSGLINELEN, p->drop ); >Release-Note: >Audit-Trail: >Unformatted: