From owner-p4-projects@FreeBSD.ORG  Mon Aug 18 10:44:54 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 4B23B37B407; Mon, 18 Aug 2003 10:44:52 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9470737B480
	for <perforce@freebsd.org>; Mon, 18 Aug 2003 10:44:48 -0700 (PDT)
Received: from mail.speakeasy.net (mail15.speakeasy.net [216.254.0.215])
	by mx1.FreeBSD.org (Postfix) with ESMTP id BE5BE442C8
	for <perforce@freebsd.org>; Mon, 18 Aug 2003 10:18:45 -0700 (PDT)
	(envelope-from jhb@FreeBSD.org)
Received: (qmail 9890 invoked from network); 18 Aug 2003 17:18:45 -0000
Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63])
	(envelope-sender <jhb@FreeBSD.org>)encrypted SMTP
	for <rwatson@FreeBSD.org>; 18 Aug 2003 17:18:45 -0000
Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1])
	by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id h7IHIh9s085386;
	Mon, 18 Aug 2003 13:18:43 -0400 (EDT)
	(envelope-from jhb@FreeBSD.org)
Message-ID: <XFMail.20030818131907.jhb@FreeBSD.org>
X-Mailer: XFMail 1.5.4 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <20030816164300.GS395@garage.freebsd.pl>
Date: Mon, 18 Aug 2003 13:19:07 -0400 (EDT)
From: John Baldwin <jhb@FreeBSD.org>
To: Pawel Jakub Dawidek <nick@garage.freebsd.pl>
cc: Perforce Change Reviews <perforce@freebsd.org>
cc: Robert Watson <rwatson@FreeBSD.org>
Subject: Re: PERFORCE change 35655 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Aug 2003 17:44:55 -0000


On 16-Aug-2003 Pawel Jakub Dawidek wrote:
> On Wed, Aug 06, 2003 at 02:20:44PM -0700, Robert Watson wrote:
> +> -    mode ~= cmask;
> +> +    mode = mode &~ cmask;
> 
> IMHO this is a style bug.
> 
> This should be: mode = mode & ~cmask;
> 
> On time, when I was tired, I've spend few minutes wondering why 'foo'
> after this operation isn't equal to 'foo - bar':)
> 
>       foo =- bar;

I prefer 'mode &= ~cmask' myself.

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/