From owner-svn-src-all@freebsd.org Thu Nov 23 03:17:44 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AF692DBBC0C for ; Thu, 23 Nov 2017 03:17:44 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-pl0-x22a.google.com (mail-pl0-x22a.google.com [IPv6:2607:f8b0:400e:c01::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 757DE789CD for ; Thu, 23 Nov 2017 03:17:44 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-pl0-x22a.google.com with SMTP id s10so1913714plj.5 for ; Wed, 22 Nov 2017 19:17:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=xKSupK6nA7YuuHyNbvbLc3fVot5E0GGpvjRVTXk23Yo=; b=WxShROIeBGURzLqbofnybLIGkn9MJjqYUjqBKn4a7954+ModPL8qaG/IAv7yl3z7vo GCXTQHN2CMmhmvLRDI0TPefFS5L974K5o1YaDSs1UD+/KXzUamABg+swy0cQlvaskuwO yaDhjjLUcI3jQ5V2W+JWEIM70A37Wha7vNos/y2MLpQ5XBAI3NK5EmsZAvxlAdFkOlBb rn5udd5+Fp7i9jHg7YG1a4/DErFvKwpKNs6QBjZFuuYoUFn+9T/5W5MD+SSAX9pcll+1 Tuu6Pnfe2ue4ZB7eR1rvspBea/MKWQOoxjLzY+ohiaMXtRfljMTB1Zhv+87Otyn/Hh37 Ip9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=xKSupK6nA7YuuHyNbvbLc3fVot5E0GGpvjRVTXk23Yo=; b=pb9bCpc0hriDYDdG8mwFfdQq16/SRphUD77w7g2Tg8frgdSj0HRLQcajm+WK7H0tSx eb8dn++oqaFH+ksycmseiEDC5jU4WtFQIqyiu0OPsNRQeDiG8ZbYKwKmlNuyNfDiyi8U cJjkWb7TEUhXVusX7roJYo7mzJmCg8s3Mp9TWrpkSfY0GRYjXQv8nuTAmn01m/X6ryvT nV2VVq9f1Fujdfs/vfLm04fbJ+jOgjnqRNabeOHXBjZKvufM3pAIxUhSK5HpLsWKGk5q m5asczoH4cLb+BwZJYa+12O8ZLPO+YKyAg15zCAUiZNIlg8/WyQnj9aV3b24T8Cmr2iV trkw== X-Gm-Message-State: AJaThX6vbdwc94+o1B6y2Cpq+hgCTgWbS6PU1Y3OQmozU+T0deZZCy1u B3ofZ1Ypmmz3e99GSsqzmDu1tWe1+BkWRg== X-Google-Smtp-Source: AGs4zMYaObV/U6D4Le0fdYlVhX3HTySEvzpC5dJSwr8ilTChUkIWJgH5u6yBLPHWUjGUcTWYgK4O6A== X-Received: by 10.84.237.9 with SMTP id s9mr23075524plk.417.1511407063895; Wed, 22 Nov 2017 19:17:43 -0800 (PST) Received: from mutt-hbsd (62-210-37-82.rev.poneytelecom.eu. [62.210.37.82]) by smtp.gmail.com with ESMTPSA id r18sm27156241pge.87.2017.11.22.19.17.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 22 Nov 2017 19:17:43 -0800 (PST) Date: Wed, 22 Nov 2017 22:17:20 -0500 From: Shawn Webb To: Mateusz Guzik Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r326107 - in head/sys: kern sys Message-ID: <20171123031720.4iyoyvfyhxsltexw@mutt-hbsd> References: <201711222204.vAMM44FW023951@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7nc7fposwnz2k7e7" Content-Disposition: inline In-Reply-To: <201711222204.vAMM44FW023951@repo.freebsd.org> X-Operating-System: FreeBSD mutt-hbsd 12.0-CURRENT FreeBSD 12.0-CURRENT X-PGP-Key: http://pgp.mit.edu/pks/lookup?op=vindex&search=0x6A84658F52456EEE User-Agent: NeoMutt/20171027 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Nov 2017 03:17:44 -0000 --7nc7fposwnz2k7e7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 22, 2017 at 10:04:04PM +0000, Mateusz Guzik wrote: > Author: mjg > Date: Wed Nov 22 22:04:04 2017 > New Revision: 326107 > URL: https://svnweb.freebsd.org/changeset/base/326107 >=20 > Log: > locks: pass the found lock value to unlock slow path > =20 > This avoids an explicit read later. > =20 > While here whack the cheaply obtainable 'tid' argument. >=20 > Modified: > head/sys/kern/kern_mutex.c > head/sys/kern/kern_rwlock.c > head/sys/kern/kern_sx.c > head/sys/sys/mutex.h > head/sys/sys/rwlock.h > head/sys/sys/sx.h This breaks ZFS: https://gist.github.com/lattera/93faa9c47ccc985ebda039ab31641c2c Thanks, --=20 Shawn Webb Cofounder and Security Engineer HardenedBSD GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE --7nc7fposwnz2k7e7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEKrq2ve9q9Ia+iT2eaoRlj1JFbu4FAloWPb8ACgkQaoRlj1JF bu6J6xAAhjqzFF2CmV8RRbER7RU4kVeD0YwC71Loet/c7wwA2bX6eJWgBz3fT15Q qHdCWqo5lLwBg12ifF0eU05INH/9NpN9SPYPJ6e7ZUD4Z1anzMFggdmqak6Ku0nM TKS4bPwJGKSk9ndOhmf/NqnyfAikrA+mVsgGAVelzn6xBWC7gdNXWAS3p70/ddtP fpG1dFzXdWC3dfp4fghs2t8kzqFRQ0c5MZy1FobMv3Q8Qr4GA0yPBd8whHyaQvo/ euwo053hMZmPmKwXi6hAP215gv9573BByFWpa2+LLyhJhB16OwvFDpbffut0Ylws JCrkxxOGPVGhxVvxe9oXRYFHbPZgP3/T0IehTE+oEfHctJDBedhP2CWb+VD4cRrN GCEVFzGofyZaDl51sf2jwSqWesNcIukicfhuHjyB1VPEx50mCxYq1KgGAg1aaSRO zORmmK/AC1Q0sWA21WrAEikt5hVQCQQb1t5qr/QiOoCSuX5Om7UPmLfSefoiirbU RAZ4AbRrszCA8eEGGF+UVxHHO59dyBFemTMM4SBhJDTLBMMfG4XFkERVeW916Hld PQCJvQflhSMAJZwZUGMyZNu3O7z4GSh3XU8OCMd+mQ3lZJ+uPlG6/5XZVOGsqNaf Wd2gWUiqOXXrr5uCJBKqPaEB04KFKh85fqVOkGX4Fps4WlSS6y8= =+HQZ -----END PGP SIGNATURE----- --7nc7fposwnz2k7e7--