From owner-svn-src-all@freebsd.org Tue Jun 30 17:16:02 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D40D935142A; Tue, 30 Jun 2020 17:16:02 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49x9xG5DDFz3Ssw; Tue, 30 Jun 2020 17:16:02 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from [192.168.1.10] (c-98-207-126-143.hsd1.ca.comcast.net [98.207.126.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: rpokala) by smtp.freebsd.org (Postfix) with ESMTPSA id EDC9223297; Tue, 30 Jun 2020 17:16:01 +0000 (UTC) (envelope-from rpokala@freebsd.org) User-Agent: Microsoft-MacOutlook/16.38.20061401 Date: Tue, 30 Jun 2020 10:15:57 -0700 Subject: Re: svn commit: r362794 - head/sys/compat/linuxkpi/common/include/linux From: Ravi Pokala To: Hans Petter Selasky , , , Message-ID: <644D442D-18C4-402E-B0F2-ED45D7900538@panasas.com> Thread-Topic: svn commit: r362794 - head/sys/compat/linuxkpi/common/include/linux References: <202006300841.05U8fYMe044989@repo.freebsd.org> In-Reply-To: <202006300841.05U8fYMe044989@repo.freebsd.org> Mime-version: 1.0 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jun 2020 17:16:02 -0000 Thank you! -Ravi (rpokala@) =EF=BB=BF-----Original Message----- From: on behalf of Hans Petter Selasky <= hselasky@FreeBSD.org> Date: 2020-06-30, Tuesday at 01:41 To: , , Subject: svn commit: r362794 - head/sys/compat/linuxkpi/common/include/linu= x Author: hselasky Date: Tue Jun 30 08:41:33 2020 New Revision: 362794 URL: https://svnweb.freebsd.org/changeset/base/362794 Log: Document the is_signed(), type_max() and type_min() function macros i= n the LinuxKPI. Try to make the function argument more readable. Suggested by: several MFC after: 1 week Sponsored by: Mellanox Technologies Modified: head/sys/compat/linuxkpi/common/include/linux/kernel.h Modified: head/sys/compat/linuxkpi/common/include/linux/kernel.h =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D --- head/sys/compat/linuxkpi/common/include/linux/kernel.h Tue Jun 30 0= 7:37:24 2020 (r362793) +++ head/sys/compat/linuxkpi/common/include/linux/kernel.h Tue Jun 30 0= 8:41:33 2020 (r362794) @@ -564,20 +564,33 @@ linux_ratelimited(linux_ratelimit_t *rl) #define __is_constexpr(x) \ __builtin_constant_p(x) -#define is_signed(x) (((x)-1 / (x)2) =3D=3D (x)0) +/* + * The is_signed() macro below returns true if the passed data type is + * signed. Else false is returned. + */ +#define is_signed(datatype) (((datatype)-1 / (datatype)2) =3D=3D (datatype= )0) -#define type_max(x) ( \ - (sizeof(x) >=3D 8) ? (is_signed(x) ? INT64_MAX : UINT64_MAX) : \ - (sizeof(x) >=3D 4) ? (is_signed(x) ? INT32_MAX : UINT32_MAX) : \ - (sizeof(x) >=3D 2) ? (is_signed(x) ? INT16_MAX : UINT16_MAX) : \ - (is_signed(x) ? INT8_MAX : UINT8_MAX) \ +/* + * The type_max() macro below returns the maxium positive value the + * passed data type can hold. + */ +#define type_max(datatype) ( \ + (sizeof(datatype) >=3D 8) ? (is_signed(datatype) ? INT64_MAX : UINT64_= MAX) : \ + (sizeof(datatype) >=3D 4) ? (is_signed(datatype) ? INT32_MAX : UINT32_= MAX) : \ + (sizeof(datatype) >=3D 2) ? (is_signed(datatype) ? INT16_MAX : UINT16_= MAX) : \ + (is_signed(datatype) ? INT8_MAX : UINT8_MAX) \ ) -#define type_min(x) ( \ - (sizeof(x) >=3D 8) ? (is_signed(x) ? INT64_MIN : 0) : \ - (sizeof(x) >=3D 4) ? (is_signed(x) ? INT32_MIN : 0) : \ - (sizeof(x) >=3D 2) ? (is_signed(x) ? INT16_MIN : 0) : \ - (is_signed(x) ? INT8_MIN : 0) \ +/* + * The type_min() macro below returns the minimum value the passed + * data type can hold. For unsigned types the minimum value is always + * zero. For signed types it may vary. + */ +#define type_min(datatype) ( \ + (sizeof(datatype) >=3D 8) ? (is_signed(datatype) ? INT64_MIN : 0) : \ + (sizeof(datatype) >=3D 4) ? (is_signed(datatype) ? INT32_MIN : 0) : \ + (sizeof(datatype) >=3D 2) ? (is_signed(datatype) ? INT16_MIN : 0) : \ + (is_signed(datatype) ? INT8_MIN : 0) \ ) #endif /* _LINUX_KERNEL_H_ */