Date: Fri, 13 Aug 2004 18:37:56 -0400 (EDT) From: Robert Watson <rwatson@FreeBSD.org> To: Max Laier <max@love2party.net> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net rtsock.c Message-ID: <Pine.NEB.3.96L.1040813183645.73100V-100000@fledge.watson.org> In-Reply-To: <200408140032.32139.max@love2party.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 14 Aug 2004, Max Laier wrote:
> On Saturday 14 August 2004 00:23, Robert Watson wrote:
> > rwatson 2004-08-13 22:23:21 UTC
> >
> > FreeBSD src repository
> >
> > Modified files:
> > sys/net rtsock.c
> > Log:
> > Use IFQ_SET_MAXLEN() to set the maximum queue depth of the routing
> > socket netisr queue.
>
> Well, I suggest to use IFQ_* macros only on queues that are
> IFQ_SET_READY'ed as well. i.e. as long as you don't use IFQ_{EN,DE}QUEUE
> with the queue there is not much point in using IFQ_SET_MAXLEN either.
> It'd just add noise to searches for IFQ_*
>
> I don't think that there are plans to use ALTQ disciplines on the netisr
> queues, are there?
No, that wouldn't really make sense, as we want a reliable record stream,
really, and the protocol in question wouldn't benefit from RED, etc. Do
you suggest, then, just backing this out? Some of the other ifq
abstractions are used, such as IFF_HANDOFF()...
Robert N M Watson FreeBSD Core Team, TrustedBSD Projects
robert@fledge.watson.org Principal Research Scientist, McAfee Research
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1040813183645.73100V-100000>