From owner-freebsd-stable@FreeBSD.ORG Mon Sep 12 03:53:01 2011 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4E59D106564A; Mon, 12 Sep 2011 03:53:01 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-gx0-f179.google.com (mail-gx0-f179.google.com [209.85.161.179]) by mx1.freebsd.org (Postfix) with ESMTP id EEA218FC15; Mon, 12 Sep 2011 03:53:00 +0000 (UTC) Received: by gxk1 with SMTP id 1so3385350gxk.10 for ; Sun, 11 Sep 2011 20:53:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=AZjgCRNEF49ypbde3XOx8VfcEvUn2SNFbUXIwPyYySw=; b=j4LNG2saoBo7FhVjTGz9x/hbhCkCXMMPsKXwAVL/NshuluVVdQDDnQjlLdCEcKi4f8 nHCuW/UdVXyzhquj7ipxdcJsCHeGpbhq1DFbjM25CCGEwZCqasq8BfoLLjPAfGlWFZM2 mayd8jJx85GoBZXIifLijbRjNbwzb2M+ISJ0Q= MIME-Version: 1.0 Received: by 10.236.89.70 with SMTP id b46mr23029125yhf.38.1315799580099; Sun, 11 Sep 2011 20:53:00 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.236.111.42 with HTTP; Sun, 11 Sep 2011 20:53:00 -0700 (PDT) In-Reply-To: <4E6D34FE.70703@incore.de> References: <4E64933E.8030908@incore.de> <201109061104.43409.jhb@freebsd.org> <4E6D34FE.70703@incore.de> Date: Mon, 12 Sep 2011 11:53:00 +0800 X-Google-Sender-Auth: bGoF5I5GtzI9wfPRFkqzd7YmSpM Message-ID: From: Adrian Chadd To: Andreas Longwitz Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-stable@freebsd.org, John Baldwin Subject: Re: UFS_DIRHASH panics on a dozen server within 30 hours X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2011 03:53:01 -0000 On 12 September 2011 06:23, Andreas Longwitz wrote: > > Yes. I found that megarc often wants a buffer of 12868 bytes, but the > controller sends always 25412 bytes back. Because this seems to be an > error in megarc I have submitted a patch for the existing PR ports/137938. > > Furthermore I saw some sporadic answers of the controller to megarc > ioctl's with much more data than the buffer size stated by megarc. > Therefore I still use the maximum size in my updated patch in kern/155658. Just a comment about that kernel PR: You're doing a 25k allocation (why not just go with an even 32k?) but you're not enforcing anywhere that if au_length > your #defined value, the malloc size is made larger. I know it's a nitpick, but if it were me doing a change, I'd use MAX(au_length, MAX_AMR_IOCTL) when doing the malloc. 2c, Adrian