From owner-freebsd-bugs@FreeBSD.ORG Sun Oct 30 09:30:14 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 204651065673 for ; Sun, 30 Oct 2011 09:30:14 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D572A8FC08 for ; Sun, 30 Oct 2011 09:30:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p9U9UCRE086808 for ; Sun, 30 Oct 2011 09:30:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p9U9UCV9086806; Sun, 30 Oct 2011 09:30:12 GMT (envelope-from gnats) Resent-Date: Sun, 30 Oct 2011 09:30:12 GMT Resent-Message-Id: <201110300930.p9U9UCV9086806@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Henning Petersen Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C64251065672 for ; Sun, 30 Oct 2011 09:20:42 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id B64BE8FC17 for ; Sun, 30 Oct 2011 09:20:42 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p9U9KgWC071638 for ; Sun, 30 Oct 2011 09:20:42 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id p9U9Kgju071637; Sun, 30 Oct 2011 09:20:42 GMT (envelope-from nobody) Message-Id: <201110300920.p9U9Kgju071637@red.freebsd.org> Date: Sun, 30 Oct 2011 09:20:42 GMT From: Henning Petersen To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: bin/162164: Misplaced parenthesis in rshd.c X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Oct 2011 09:30:14 -0000 >Number: 162164 >Category: bin >Synopsis: Misplaced parenthesis in rshd.c >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Oct 30 09:30:12 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Henning Petersen >Release: FreeBSD-current >Organization: >Environment: >Description: Misplaced parenthesis in rshd.c . >How-To-Repeat: >Fix: diff -u -p -r1.51 rshd.c --- libexec/rshd/rshd.c 11 May 2005 02:41:39 -0000 1.51 +++ libexec/rshd/rshd.c 30 Oct 2011 08:53:04 -0000 @@ -317,7 +317,7 @@ doit(struct sockaddr *fromp) } if ((pam_err = pam_set_item(pamh, PAM_RUSER, ruser)) != PAM_SUCCESS || - (pam_err = pam_set_item(pamh, PAM_RHOST, rhost) != PAM_SUCCESS)) { + (pam_err = pam_set_item(pamh, PAM_RHOST, rhost)) != PAM_SUCCESS) { syslog(LOG_ERR|LOG_AUTH, "pam_set_item(): %s", pam_strerror(pamh, pam_err)); rshd_errx(1, "Login incorrect."); Patch attached with submission follows: diff -u -p -r1.51 rshd.c --- libexec/rshd/rshd.c 11 May 2005 02:41:39 -0000 1.51 +++ libexec/rshd/rshd.c 30 Oct 2011 08:53:04 -0000 @@ -317,7 +317,7 @@ doit(struct sockaddr *fromp) } if ((pam_err = pam_set_item(pamh, PAM_RUSER, ruser)) != PAM_SUCCESS || - (pam_err = pam_set_item(pamh, PAM_RHOST, rhost) != PAM_SUCCESS)) { + (pam_err = pam_set_item(pamh, PAM_RHOST, rhost)) != PAM_SUCCESS) { syslog(LOG_ERR|LOG_AUTH, "pam_set_item(): %s", pam_strerror(pamh, pam_err)); rshd_errx(1, "Login incorrect."); >Release-Note: >Audit-Trail: >Unformatted: