Date: Mon, 25 Feb 2019 17:58:09 +0000 From: Brooks Davis <brooks@freebsd.org> To: Matt Macy <mmacy@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r344487 - in head/sys: conf gnu/gcov Message-ID: <20190225175809.GB47081@spindle.one-eyed-alien.net> In-Reply-To: <201902232114.x1NLE0cH085345@repo.freebsd.org> References: <201902232114.x1NLE0cH085345@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--9jxsPFA5p3P2qPhR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Feb 23, 2019 at 09:14:00PM +0000, Matt Macy wrote: > Author: mmacy > Date: Sat Feb 23 21:14:00 2019 > New Revision: 344487 > URL: https://svnweb.freebsd.org/changeset/base/344487 >=20 > Log: > gcov support > =20 > add gcov support and export results as files in debugfs We had a brief discussion of this commit within a subset of core. This addition of GPLv2 code is fine as the code is easily removal to a module (per kmoore@) should the day come that we're read to evict all GPL code. The modest increase in activation energy for that task seems worth it for the short-term gains of reduced integration cost (this code will greatly improve our ZFS-on-Linux test coverage.) Rod rightly points out that we haven't accepted SPDX tags alone as license statements. The standard GPL v2.0 boiler plate should be added to this file along side the tag. An additional issue is that the a warning tag was not added to sys/conf/files. A warning along the lines of: warning "kernel contains GPLv2 licensed GCOV" needs to be added. This commit needed more through review. We intend to update our license policy to require core sign off for new GPL code to ensure we're not adding new, tightly integrated dependencies, to document that we're doing so knowingly, and to make sure steps aren't missed. The current document is at: https://www.freebsd.org/internal/software-license.html -- Brooks --9jxsPFA5p3P2qPhR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJcdCywAAoJEKzQXbSebgfAbL8H/A9EBVqx4ZQWU2cJDmUFQE8A NIA5ft21MhjOrh9UD/vFrYiBb75muK1tnIxlnk6wGVs2fYNCWR5SgJ0ng0559xdi s7UsouFVfS7fOdm111CAwrmUFxt6NoSHnVPvKO0FxLxoz7zyyC9L5rKxEy4vq4ua 6EpMqh+S8UGWCOUrEDFmFHJwVWnv0uFiMjn9L7uytIA4yzvpT1bCDZToGek+FKGN c+oo9HMKlWQUilPMJPkP5dd1dzADmpad1y8zhX6sn9p0cNGHtaUCYc8Mcy+BXQ3q 8G1YB5G26q6oWBW0kEvXm/ZLFsRuKQ7gnN3d5zfjH0LNNCjQTSuGxLn2xKQecEc= =tVeO -----END PGP SIGNATURE----- --9jxsPFA5p3P2qPhR--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190225175809.GB47081>