From nobody Sat Jun 6 13:03:50 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gXdm6555sz6ggD5 for ; Sat, 06 Jun 2026 13:03:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gXdm64F9Cz3KbL for ; Sat, 06 Jun 2026 13:03:50 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780751030; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=di0uJvc/jcdRMtTRKZZvGu0JFZnC92SIX5PuyKEkNds=; b=pnbk7NLZfDmQIh3C60gkHPhKz4K8vylKkBPrjEYGeCbbx3UH5hQQPjzmkCvROjX+af6nYE oLcMqadwiuMGUChCmnJtKVxyUOC3gtFLgmk7dWN0AOAjvaRNHAJGEsLSMDtmZLIDtSRXym XL2Jy/0mq6jEeoKBtHZ8w/R7xJwFc4wZYjia9FSoNqCQFjvpnSb0D7GS/9Cst+kbYszyla tA5mBcdOkUQR1BS0atu5Q22xmhrbOMVF4/yGACmXHsvAdUHTWaDbgN6epHmX0yE1bajogA WekI6mZNYd6KYhJDW8i+wwbTM4J2FyrX3N8fF00OKZwbbG0OCXSKUf2BDTIZyA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1780751030; a=rsa-sha256; cv=none; b=iOv3TTZPDMW333Zoo3B/mvoPkOLXnYWpEQroCR7umtqa1mJWs8Ttst7tJfDCUc/Oal2D35 HqLSVbE/tuE3k/uLpjK1fR4Fnj1IdPixi5IyZ8icNiB21znstKR2RSJPX7sPa1BHNRwMHo AHymCsjwAe94vE7faV+BoPLQk+tpouI2K9XFOt1JoJfevAOdFhHB8QOrJunKBOvXOaOjtZ KSITWf6cw3gF+niVpRlM4r5uvNcDWhnszguh9A4vScvV0BAZk6UvLN9Xfsft21eEQUL9OJ 9u6DEm7S4x9cB9PAne+oWvlpyVpn1KFGbsTjQasihiSnVF8GfhETky7/KRlP7g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780751030; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=di0uJvc/jcdRMtTRKZZvGu0JFZnC92SIX5PuyKEkNds=; b=LkCLAaVtFeY83a1RjhW8FwvKonOX3x0pbuQaT85dd8fqPx3v17grAgLf4QnSY8N9mPVyTW jY8JCIjQqx9pUboJJt2zS1M/vsGHdaQ4bxcJsiPr30+1MZa/xbVxMSC4E7JkH3qCL2cL2j pa+OAvLdwlQC3atjcYaN0/2FYOtgKV75ugqtCYwJJFJe+iX2F+2WovM24irr5+YmBq+5rD mhPGlLEXfZlKq/ZnsetWTL5yEaFj3DQ+Ite8WHnwvXvDhvNhM7uTB2bjKsE8LRDYqDchx0 gu+2sH9mkYb3FRtizub9wrovhDe8w7xxpsNMYEihyc3Tv+6qD+q1oVgL7j6dFA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gXdm63rF1z1Xc for ; Sat, 06 Jun 2026 13:03:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 33597 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 06 Jun 2026 13:03:50 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 1ee4b5fd824a - main - fork: Drop an uneeded PHOLD/PRELE pair List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1ee4b5fd824aa93f9a20df6bd5dad50c7e32fe05 Auto-Submitted: auto-generated Date: Sat, 06 Jun 2026 13:03:50 +0000 Message-Id: <6a241ab6.33597.217eb56e@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=1ee4b5fd824aa93f9a20df6bd5dad50c7e32fe05 commit 1ee4b5fd824aa93f9a20df6bd5dad50c7e32fe05 Author: Mark Johnston AuthorDate: 2026-06-06 12:52:15 +0000 Commit: Mark Johnston CommitDate: 2026-06-06 12:52:15 +0000 fork: Drop an uneeded PHOLD/PRELE pair Support for swapping out kernel stacks was removed, so the PHOLD has no purpose. (And even before that, it's not clear why a swapout here would have been problematic.) Reviewed by: kib MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D57486 --- sys/kern/kern_fork.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/sys/kern/kern_fork.c b/sys/kern/kern_fork.c index 36647ae44f08..75f8413e5f36 100644 --- a/sys/kern/kern_fork.c +++ b/sys/kern/kern_fork.c @@ -675,11 +675,6 @@ do_fork(struct thread *td, struct fork_req *fr, struct proc *p2, struct thread * callout_init_mtx(&p2->p_itcallout, &p2->p_mtx, 0); - /* - * This begins the section where we must prevent the parent - * from being swapped. - */ - _PHOLD(p1); PROC_UNLOCK(p1); /* @@ -786,10 +781,6 @@ do_fork(struct thread *td, struct fork_req *fr, struct proc *p2, struct thread * */ knote_fork(p1->p_klist, p2->p_pid); - /* - * Now can be swapped. - */ - _PRELE(p1); PROC_UNLOCK(p1); SDT_PROBE3(proc, , , create, p2, p1, fr->fr_flags);