From owner-freebsd-bugs@FreeBSD.ORG Sat Feb 13 08:00:14 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CEA32106566C for ; Sat, 13 Feb 2010 08:00:14 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 8BE748FC14 for ; Sat, 13 Feb 2010 08:00:14 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o1D80ECk052700 for ; Sat, 13 Feb 2010 08:00:14 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o1D80EuU052699; Sat, 13 Feb 2010 08:00:14 GMT (envelope-from gnats) Resent-Date: Sat, 13 Feb 2010 08:00:14 GMT Resent-Message-Id: <201002130800.o1D80EuU052699@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Graham Menhennitt Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A12C1106566C for ; Sat, 13 Feb 2010 07:58:30 +0000 (UTC) (envelope-from gfm@menhennitt.com.au) Received: from fallbackmx08.syd.optusnet.com.au (fallbackmx08.syd.optusnet.com.au [211.29.132.10]) by mx1.freebsd.org (Postfix) with ESMTP id 398A78FC16 for ; Sat, 13 Feb 2010 07:58:29 +0000 (UTC) Received: from mail01.syd.optusnet.com.au (mail01.syd.optusnet.com.au [211.29.132.182]) by fallbackmx08.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id o1D60Nbu005716 for ; Sat, 13 Feb 2010 17:00:23 +1100 Received: from maxwell.mencon.com.au (c122-107-224-152.mckinn3.vic.optusnet.com.au [122.107.224.152]) by mail01.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id o1D60KQE002008 for ; Sat, 13 Feb 2010 17:00:21 +1100 Received: by maxwell.mencon.com.au (Postfix, from userid 1001) id C7E085D3A; Sat, 13 Feb 2010 17:00:14 +1100 (EST) Message-Id: <20100213060014.C7E085D3A@maxwell.mencon.com.au> Date: Sat, 13 Feb 2010 17:00:14 +1100 (EST) From: Graham Menhennitt To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: kern/143868: allow Atheros watchdog timeout to be tunable X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Graham Menhennitt List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Feb 2010 08:00:15 -0000 >Number: 143868 >Category: kern >Synopsis: allow Atheros watchdog timeout to be tunable >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sat Feb 13 08:00:14 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Graham Menhennitt >Release: FreeBSD 8.0-STABLE i386 >Organization: >Environment: System: FreeBSD maxwell.mencon.com.au 8.0-STABLE FreeBSD 8.0-STABLE #24: Sun Feb 14 00:56:04 EST 2010 root@chief-freebsd.mencon.com.au:/usr/obj/usr/src/sys/maxwell i386 ath0: mem 0xa0010000-0xa001ffff irq 15 at device 17.0 on pci0 ath0: [ITHREAD] ath0: AR5413 mac 10.5 RF5413 phy 6.1 >Description: The Atheros wireless driver uses a hard-coded value for the watchdog timer. This value is too low on slow hardware (e.g. Soekris net5501). The attached patch allows the timer threshold to be tuned via sysctl. >How-To-Repeat: >Fix: *** if_ath.c Sat Feb 13 13:47:37 2010 --- if_ath.c_save Tue Sep 8 02:41:18 2009 *************** *** 286,295 **** SYSCTL_INT(_hw_ath, OID_AUTO, bstuck, CTLFLAG_RW, &ath_bstuck_threshold, 0, "max missed beacon xmits before chip reset"); - static int ath_wd_timer_threshold = 5; /* watchdog timer threshold */ - SYSCTL_INT(_hw_ath, OID_AUTO, wd_timer_threshold, CTLFLAG_RW, &ath_wd_timer_threshold, - 0, "watchdog timer threshold"); - #ifdef ATH_DEBUG enum { ATH_DEBUG_XMIT = 0x00000001, /* basic xmit operation */ --- 286,291 ---- *************** *** 1894,1900 **** goto nextfrag; } ! sc->sc_wd_timer = ath_wd_timer_threshold; } } --- 1890,1896 ---- goto nextfrag; } ! sc->sc_wd_timer = 5; } } *************** *** 6906,6912 **** goto bad2; } } ! sc->sc_wd_timer = ath_wd_timer_threshold; ifp->if_opackets++; sc->sc_stats.ast_tx_raw++; --- 6902,6908 ---- goto bad2; } } ! sc->sc_wd_timer = 5; ifp->if_opackets++; sc->sc_stats.ast_tx_raw++; >Release-Note: >Audit-Trail: >Unformatted: