From owner-freebsd-net Wed Aug 30 10:24:32 2000 Delivered-To: freebsd-net@freebsd.org Received: from whistle.com (s205m131.whistle.com [207.76.205.131]) by hub.freebsd.org (Postfix) with ESMTP id D479437B424; Wed, 30 Aug 2000 10:24:26 -0700 (PDT) Received: (from smap@localhost) by whistle.com (8.10.0/8.10.0) id e7UHOQF29606; Wed, 30 Aug 2000 10:24:26 -0700 (PDT) Received: from bubba.whistle.com( 207.76.205.7) by whistle.com via smap (V2.0) id xma029604; Wed, 30 Aug 2000 10:24:21 -0700 Received: (from archie@localhost) by bubba.whistle.com (8.9.3/8.9.3) id KAA30942; Wed, 30 Aug 2000 10:24:21 -0700 (PDT) (envelope-from archie) From: Archie Cobbs Message-Id: <200008301724.KAA30942@bubba.whistle.com> Subject: Re: [Call for review] ICMP error generation fixes In-Reply-To: <20000830150327.C69333@sunbay.com> "from Ruslan Ermilov at Aug 30, 2000 03:03:27 pm" To: Ruslan Ermilov Date: Wed, 30 Aug 2000 10:24:21 -0700 (PDT) Cc: committers@FreeBSD.org, net@FreeBSD.org, Garrett Wollman , Bill Fenner , Darren Reed , Kannan Varadhan , Frank Volf X-Mailer: ELM [version 2.4ME+ PL82 (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org Ruslan Ermilov writes: > http://people.FreeBSD.org/~ru/icmp-fixes.2 > > 5. Following the suggestion from Darren Reed, ip_output() now expects all > three fields, ip_len, ip_off and ip_id(!) in host byte order. It was You need to add a NTOHS(ip->ip_id) to div_output() as well. Did you grep for all occurrences of calls to ip_output()? There may be others as well. -Archie ___________________________________________________________________________ Archie Cobbs * Whistle Communications, Inc. * http://www.whistle.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message