From owner-p4-projects@FreeBSD.ORG Mon Jun 21 01:15:56 2010 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 5AF921065672; Mon, 21 Jun 2010 01:15:56 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1EAFA106566B; Mon, 21 Jun 2010 01:15:56 +0000 (UTC) (envelope-from ivoras@gmail.com) Received: from mail-ww0-f54.google.com (mail-ww0-f54.google.com [74.125.82.54]) by mx1.freebsd.org (Postfix) with ESMTP id 58C5F8FC14; Mon, 21 Jun 2010 01:15:54 +0000 (UTC) Received: by wwg30 with SMTP id 30so2921514wwg.13 for ; Sun, 20 Jun 2010 18:15:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:sender:received :in-reply-to:references:from:date:x-google-sender-auth:message-id :subject:to:cc:content-type:content-transfer-encoding; bh=RBmipTLVcok7g3yZ054CVFjbctFfl1eO3d8eqQ6wGIo=; b=EDadMLqsAPUZUS+JvilR5if5Shppo8pqHygQ2keIl6756ng0W/hE6G+ZZ8Lpr5xrf/ uWpdK4T76StZnnO6wTD3mg7adc4Cz9gS7FHpXVAp0grwXkb2JofMR/QWiKyqoyW2Sad2 OWb4Q9yXbW5ITN/5dpTtw8gatpZuGeDUFfkM8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; b=BZaEO0oJsn/Kq+SSsdlTQZAS8BgzHF0ifoALJzXB7IVmpkQblWAe5Qk1vaDKB+Z/WU MrljRYlx9Sia1Q3gpM7fMefcza18vNgTFr1KGq0XdhZ+Dm+fwtwoXAbH0z92B7f55hbE B4bNtMRILNDsHXQfXix5F4CNkHF0A4M/X/TZU= Received: by 10.216.88.72 with SMTP id z50mr2937412wee.60.1277082954200; Sun, 20 Jun 2010 18:15:54 -0700 (PDT) MIME-Version: 1.0 Sender: ivoras@gmail.com Received: by 10.216.89.197 with HTTP; Sun, 20 Jun 2010 18:15:34 -0700 (PDT) In-Reply-To: References: <201006210045.o5L0jgZ3009138@repoman.freebsd.org> From: Ivan Voras Date: Mon, 21 Jun 2010 03:15:34 +0200 X-Google-Sender-Auth: NCk4OSSFFdstiln1t7RP3R34pwI Message-ID: To: Julien LAFFAYE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: Andrew Pantyukhin , Perforce Change Reviews Subject: Re: PERFORCE change 180026 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jun 2010 01:15:56 -0000 On 21 June 2010 02:58, Julien LAFFAYE wrote: > Hi, > > On Sun, Jun 20, 2010 at 5:45 PM, Ivan Voras wrote: >> >> http://p4web.freebsd.org/@@180026?ac=3D10 >> >> Change 180026 by ivoras@betelgeuse on 2010/06/21 00:45:03 >> >> =C2=A0 =C2=A0 =C2=A0 =C2=A0Finished most of +CONTENTS reading code, stil= l a few things to go >> =C2=A0 =C2=A0 =C2=A0 =C2=A0and certainly edge-cases resulting from the u= glyness and adhockery >> =C2=A0 =C2=A0 =C2=A0 =C2=A0of the format. >> > > Why don't you use read_plist(Package *pkg, int fd) from libpkg instead? Should I, in the light of YES_I_KNOW_THE_API_IS_RUBBISH_AND_IS_DOOMED_TO_CHANGE ? I thought the entire lib is to be rightfully scrapped and implemented as something decent.