From owner-svn-ports-all@FreeBSD.ORG  Wed Apr 15 15:38:16 2015
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id B3C0DC4C;
 Wed, 15 Apr 2015 15:38:16 +0000 (UTC)
Received: from vps.amdmi3.ru (vps.amdmi3.ru [109.234.38.216])
 by mx1.freebsd.org (Postfix) with ESMTP id 778B7EF;
 Wed, 15 Apr 2015 15:38:15 +0000 (UTC)
Received: from hive.panopticon (unknown [78.153.152.119])
 by vps.amdmi3.ru (Postfix) with ESMTPS id 3F64FB0613;
 Wed, 15 Apr 2015 18:38:14 +0300 (MSK)
Received: from hades.panopticon (hades.panopticon [192.168.0.32])
 by hive.panopticon (Postfix) with ESMTP id E7ADE868;
 Wed, 15 Apr 2015 18:38:01 +0300 (MSK)
Received: by hades.panopticon (Postfix, from userid 1000)
 id E136DC0A2B; Wed, 15 Apr 2015 18:38:06 +0300 (MSK)
Date: Wed, 15 Apr 2015 18:38:06 +0300
From: Dmitry Marakasov <amdmi3@amdmi3.ru>
To: marino@freebsd.org
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r384052 - in head/games/tomenet: . files
Message-ID: <20150415153806.GA78733@hades.panopticon>
References: <201504151354.t3FDshh1086098@svn.freebsd.org>
 <552E71F3.1030005@marino.st>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <552E71F3.1030005@marino.st>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Apr 2015 15:38:16 -0000

* John Marino (freebsd.contact@marino.st) wrote:

> > Log:
> >   - Fix build on < 10.x
> >   - Respect CC
> >   
> >   Approved by:	portmgr blanket
> > 
> > Modified:
> >   head/games/tomenet/Makefile
> >   head/games/tomenet/files/patch-makefile
> > 
> > Modified: head/games/tomenet/Makefile
> > ==============================================================================
> > --- head/games/tomenet/Makefile	Wed Apr 15 13:46:34 2015	(r384051)
> > +++ head/games/tomenet/Makefile	Wed Apr 15 13:54:43 2015	(r384052)
> > @@ -31,6 +31,12 @@ OPTIONS_DEFINE=	DOCS
> >  
> >  .include <bsd.port.options.mk>
> >  
> > +.if ${OSVERSION} < 1000000
> > +LIB_DEPENDS+=	libexecinfo.so:${PORTSDIR}/devel/libexecinfo
> > +CFLAGS+=	-I${LOCALBASE}/include
> > +LIBS+=		-L${LOCALBASE}/lib
> > +.endif
> > +
> 
> 1) OSVERSION is used without OPSYS here
> 2) it matters because DragonFly needs libexecinfo
> 3) why wasn't USES+= libexec used?

Hmm, wasn't aware of USES=execinfo and completely forgot about
dragonfly. As I guess, this actually needs unconditional USES=execinfo
and conditional flags:

.if ${OPSYS} == DragonFly || ${OSVERSION} < 1000000
CFLAGS+=	-I${LOCALBASE}/include
LIBS+=		-L${LOCALBASE}/lib
.fi

Correct?

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru      http://amdmi3.ru