From owner-svn-src-head@FreeBSD.ORG Tue May 6 22:56:12 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D47DC721; Tue, 6 May 2014 22:56:12 +0000 (UTC) Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "funkthat.com", Issuer "funkthat.com" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id AE034E84; Tue, 6 May 2014 22:56:12 +0000 (UTC) Received: from h2.funkthat.com (localhost [127.0.0.1]) by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id s46Mtp5e076286 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 6 May 2014 15:55:52 -0700 (PDT) (envelope-from jmg@h2.funkthat.com) Received: (from jmg@localhost) by h2.funkthat.com (8.14.3/8.14.3/Submit) id s46MtpEN076285; Tue, 6 May 2014 15:55:51 -0700 (PDT) (envelope-from jmg) Date: Tue, 6 May 2014 15:55:51 -0700 From: John-Mark Gurney To: Marius Strobl Subject: Re: svn commit: r265359 - head/sys/modules/sound/sound Message-ID: <20140506225551.GD43976@funkthat.com> References: <201405051431.s45EVZ2q027729@svn.freebsd.org> <7745BD19-5BAE-47BD-8DE4-10CF7E23FA9D@gmail.com> <53690381.9040909@selasky.org> <20140506160154.GA679@alchemy.franken.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140506160154.GA679@alchemy.franken.de> User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD 7.2-RELEASE i386 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.2.2 (h2.funkthat.com [127.0.0.1]); Tue, 06 May 2014 15:55:52 -0700 (PDT) Cc: Hans Petter Selasky , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers , Warner Losh X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 May 2014 22:56:13 -0000 Marius Strobl wrote this message on Tue, May 06, 2014 at 18:01 +0200: > On Tue, May 06, 2014 at 05:45:05PM +0200, Hans Petter Selasky wrote: > > On 05/05/14 22:39, Warner Losh wrote: > > > > > > On May 5, 2014, at 8:31 AM, Hans Petter Selasky wrote: > > > > > >> Author: hselasky > > >> Date: Mon May 5 14:31:34 2014 > > >> New Revision: 265359 > > >> URL: http://svnweb.freebsd.org/changeset/base/265359 > > >> > > >> Log: > > >> Build the kernel sound module without ISA DMA support for ARM and MIPS > > >> platforms, because these platforms do not implement the ISA DMA > > >> API. Else the sound modules cannot be loaded when running these > > >> platforms. > > >> > > >> MFC after: 2 weeks > > >> > > >> Modified: > > >> head/sys/modules/sound/sound/Makefile > > >> > > >> Modified: head/sys/modules/sound/sound/Makefile > > >> ============================================================================== > > >> --- head/sys/modules/sound/sound/Makefile Mon May 5 11:50:52 2014 (r265358) > > >> +++ head/sys/modules/sound/sound/Makefile Mon May 5 14:31:34 2014 (r265359) > > >> @@ -44,7 +44,8 @@ CLEANFILES+= feeder_eq_gen.h feeder_rate > > >> > > >> EXPORT_SYMS= YES # XXX evaluate > > >> > > >> -.if ${MACHINE_CPUARCH} == "sparc64" || ${MACHINE_CPUARCH} == "powerpc" > > >> +.if ${MACHINE_CPUARCH} == "sparc64" || ${MACHINE_CPUARCH} == "powerpc" || \ > > >> + ${MACHINE_CPUARCH} == "arm" || ${MACHINE_CPUARCH} == "mips" > > >> # Create an empty opt_isa.h in order to keep kmod.mk from linking in an > > >> # existing one from KERNBUILDDIR which possibly has DEV_ISA defined so > > >> # sound.ko is always built without isadma support. > > > > > > Rather than an opt-in approach here, why not lust list the three that have it since > > > they are the only ones that will ever have it? > > > > > > Warner > > > > > > > Hi, > > > > Maybe the sound DMA file belongs in its own module? > > > > It's not just sndbuf_dma.c but also the #ifdef'ed DEV_ISA code in > channel.c on architectures that have ISA but not ISA DMA support, > hence the current kludge. I thought busdma was suppose to abstract all of this away? Is it just that this was never complete? or? -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."