From owner-svn-src-all@FreeBSD.ORG Tue Oct 23 18:43:36 2012 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 983B03DA; Tue, 23 Oct 2012 18:43:36 +0000 (UTC) (envelope-from tuexen@fh-muenster.de) Received: from mail-n.franken.de (drew.ipv6.franken.de [IPv6:2001:638:a02:a001:20e:cff:fe4a:feaa]) by mx1.freebsd.org (Postfix) with ESMTP id 009448FC08; Tue, 23 Oct 2012 18:43:35 +0000 (UTC) Received: from [192.168.1.103] (p508F9AE1.dip.t-dialin.net [80.143.154.225]) (Authenticated sender: macmic) by mail-n.franken.de (Postfix) with ESMTP id A57EB1C0C0692; Tue, 23 Oct 2012 20:43:34 +0200 (CEST) Subject: Re: svn commit: r241916 - in head/sys: netinet netinet6 Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=us-ascii From: Michael Tuexen In-Reply-To: <20121024052525.T4723@besplex.bde.org> Date: Tue, 23 Oct 2012 20:43:33 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201210222149.q9MLnvrt014543@svn.freebsd.org> <20121023142219.K1008@besplex.bde.org> <20121024052525.T4723@besplex.bde.org> To: Bruce Evans X-Mailer: Apple Mail (2.1283) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Xin LI X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Oct 2012 18:43:36 -0000 On Oct 23, 2012, at 8:28 PM, Bruce Evans wrote: > On Tue, 23 Oct 2012, Michael Tuexen wrote: >=20 >> On Oct 23, 2012, at 6:23 AM, Bruce Evans wrote: >>=20 >>> On Mon, 22 Oct 2012, Xin LI wrote: >>>=20 >>>> Log: >>>> Remove __P. >>>=20 >>> This was a chance to remove style bugs in the prototypes. At least = it >>> didn't create so many new ones, unlike the original __P axing. It >>> still enlarged about a hundred by changing from Gnu style = continuation >>> to Gnu style continuation indentation with an off-by-5 error. >>=20 >> please note that the SCTP code in the FreeBSD sources is generated >> via an export script from a codebase which runs on multiple = platforms. >> The script tries to follow FreeBSDs guidelines, but is far from being >> perfect. >=20 > The export script might not like manual editing of its output. >=20 > Portability might require __P(()), and then removing it cleaning = requires > a complicated script. Maybe I wasn't clear... * The removal of __P() needs also be done upstream. I'll handle this, = not problem. I don't think we need __P on any platform. * My comment was regarding your list of formatting issues of the code. = Changing the formatting would require changing the export script. If someone "just" changes the FreeBSD sources and these changes are = not included upstream, they are lost by the next commit of rrs@ or mine. My point was: Getting rid of __P is fine and we can handle that upstream = (as any other non whitespace/formatting changes needed), but changing the = formatting is NOT that easy. I'm sorry about that and just wanted to let you know = that there is a reason why the style 9 stuff is not followed exactly within = the SCTP code. I hope this makes the situation clearer. Best regards Michael >=20 > Bruce >=20