From owner-cvs-all@FreeBSD.ORG  Thu May 12 16:07:50 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 38F6116A4CE; Thu, 12 May 2005 16:07:50 +0000 (GMT)
Received: from mailout11.sul.t-online.com (mailout11.sul.t-online.com
	[194.25.134.85])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id D02BA43D70; Thu, 12 May 2005 16:07:49 +0000 (GMT)
	(envelope-from Alexander@Leidinger.net)
Received: from fwd21.aul.t-online.de 
	by mailout11.sul.t-online.com with smtp 
	id 1DWGE0-00089C-02; Thu, 12 May 2005 18:07:48 +0200
Received: from Andro-Beta.Leidinger.net
	(rCPwn+ZvoeK4Pi2vF6+dCqyQTmO4ESOuUKfD1YrE9-HwtleQXnifY-@[217.81.91.174]) by
	fwd21.sul.t-online.de
	with esmtp id 1DWGDy-0Y32Se0; Thu, 12 May 2005 18:07:46 +0200
Received: from localhost (localhost [127.0.0.1])j4CG7igW066117;
	Thu, 12 May 2005 18:07:44 +0200 (CEST)
	(envelope-from Alexander@Leidinger.net)
Received: from 141.113.101.32 ([141.113.101.32]) by netchild.homeip.net
	(Horde MIME library) with HTTP for <Alexander@Leidinger.net>;
	Thu, 12 May	2005 18:07:43 +0200
Message-ID: <20050512180743.6z1h22fldwksgw4w@netchild.homeip.net>
X-Priority: 3 (Normal)
Date: Thu, 12 May 2005 18:07:43 +0200
From: Alexander Leidinger <Alexander@Leidinger.net>
To: Hartmut Brandt <harti@FreeBSD.org>,
	Max Okumoto <okumoto@ucsd.edu>
References: <200505121545.j4CFjENu078768@repoman.freebsd.org>
In-Reply-To: <200505121545.j4CFjENu078768@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
	charset=ISO-8859-15;
	format="flowed"
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
User-Agent: Internet Messaging Program (IMP) H3 (4.0.3) / FreeBSD-4.11
X-ID: rCPwn+ZvoeK4Pi2vF6+dCqyQTmO4ESOuUKfD1YrE9-HwtleQXnifY-@t-dialin.net
X-TOI-MSGID: 62f62e67-95b5-42e5-a92c-e6a825569834
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.bin/make job.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 12 May 2005 16:07:50 -0000

Hartmut Brandt <harti@FreeBSD.org> wrote:

> harti       2005-05-12 15:45:14 UTC
>
>  FreeBSD src repository
>
>  Modified files:
>    usr.bin/make         job.c
>  Log:
>  Do mktemp() by hand to get rid of the mktemp() warning and the
>  possible associated security hole.
>
>  Submitted by:   Max Okumoto <okumoto@ucsd.edu> (7.245)

For those which didn't looked at the src: he can't use mkstemp() since he
wants to create a fifo.

But "making a copy" and creating mkfifo() out of it looks like overkill to
me. Why not using mkdtemp() and creating a fixed name in this temporary
directory instead?

Bye,
Alexander.

-- 
http://www.Leidinger.net  Alexander @ Leidinger.net: PGP ID = B0063FE7
http://www.FreeBSD.org     netchild @ FreeBSD.org  : PGP ID = 72077137
It's ten o'clock; do you know where your processes are?