From owner-freebsd-current@FreeBSD.ORG Sun Aug 29 08:41:50 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1F93016A4CE; Sun, 29 Aug 2004 08:41:50 +0000 (GMT) Received: from mp2.macomnet.net (mp2.macomnet.net [195.128.64.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2545943D1F; Sun, 29 Aug 2004 08:41:49 +0000 (GMT) (envelope-from maxim@macomnet.ru) Received-SPF: pass (mp2.macomnet.net: domain of maxim@macomnet.ru designates 127.0.0.1 as permitted sender) receiver=mp2.macomnet.net; client_ip=127.0.0.1; envelope-from=maxim@macomnet.ru; Received: from localhost (p67klxkz@localhost [127.0.0.1]) by mp2.macomnet.net (8.12.11/8.12.11) with ESMTP id i7T8flUL079129; Sun, 29 Aug 2004 12:41:47 +0400 (MSD) (envelope-from maxim@macomnet.ru) Date: Sun, 29 Aug 2004 12:41:47 +0400 (MSD) From: Maxim Konovalov To: Jeremy Chadwick In-Reply-To: <20040817102003.P5098@mp2.macomnet.net> Message-ID: <20040829123449.Y79110@mp2.macomnet.net> References: <20040817060556.GA7458@parodius.com> <20040817102003.P5098@mp2.macomnet.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: luigi@freebsd.org cc: freebsd-current@freebsd.org Subject: Re: ipfw2 net.inet.ip.fw.verbose_limit broken X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Aug 2004 08:41:50 -0000 Hello, > On Mon, 16 Aug 2004, 23:05-0700, Jeremy Chadwick wrote: > > > Just wanted to toss this one up here. Also, apologies for not > > cross-posting this to freebsd-ipfw, but I'm not on the list; although > > they seem to be aware of it: > > > > http://lists.freebsd.org/mailman/htdig/freebsd-ipfw/2004-July/001239.html > > > > Seems that ipfw2's support for net.inet.ip.fw.verbose_limit is, to > > put it bluntly, broken. This applies to both -STABLE and -CURRENT. > > The following PR has been sitting around for quite some time... > > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/46080 I have fixed this bug in -CURRENT and will MFC it in a week to RELENG_4 and RELENG_5 with the re@ approval. > > I've managed to confirm this still exists even as of an August 5th build > > of -CURRENT. Using `logamount' directives per rule works properly as > > a workaround. > > > > I've also looked at the patch, although I'm not sure about the performance > > implications of looking up a sysctl value per packet with a matching > > ipfw2 `log' directive. No, it works in a different way. There are max_log and log_left fields in ipfw_insn_log sructure associated with each ipfw rule. They are checked on every packet matches the rule. That is why a changing verbose_limit value does not affect the existent rules. -- Maxim Konovalov