From owner-freebsd-ports  Fri Mar  8  2: 0:23 2002
Delivered-To: freebsd-ports@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 8E3A337B426
	for <freebsd-ports@hub.freebsd.org>; Fri,  8 Mar 2002 02:00:04 -0800 (PST)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id g28A02r11317;
	Fri, 8 Mar 2002 02:00:02 -0800 (PST)
	(envelope-from gnats)
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id DB15537B41B
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  8 Mar 2002 01:55:05 -0800 (PST)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id g289t5F10100;
	Fri, 8 Mar 2002 01:55:05 -0800 (PST)
	(envelope-from nobody)
Message-Id: <200203080955.g289t5F10100@freefall.freebsd.org>
Date: Fri, 8 Mar 2002 01:55:05 -0800 (PST)
From: Hendrik Scholz <hendrik@scholz.net>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-1.0
Subject: ports/35667: net/pppload patch so it doesn't show wrong values
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-ports.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-ports>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-ports>
X-Loop: FreeBSD.org


>Number:         35667
>Category:       ports
>Synopsis:       net/pppload patch so it doesn't show wrong values
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Mar 08 02:00:02 PST 2002
>Closed-Date:
>Last-Modified:
>Originator:     Hendrik Scholz
>Release:        5.0-current x86
>Organization:
NetUSE AG
>Environment:
FreeBSD deimos.raisdorf.net 5.0-CURRENT FreeBSD 5.0-CURRENT #5: Tue Feb 19 12:17:09 EST 2002     hscholz@deimos.raisdorf.net:/usr/src/sys/i386/compile/DEIMOS5  i386

>Description:
pppload is a qt program that shows the traffic on ppp lines.
When started uninitialized values (in the PPPStat struct) are used to calculate the traffic during the last period of time.

>How-To-Repeat:
Start pppload (while online or offline). It will show wrong values and sometimes even paints wrong charts due to these problems.
>Fix:
--- PPPStats.C.orig	Fri Mar  8 16:52:57 2002
+++ PPPStats.C	Fri Mar  8 16:52:37 2002
@@ -68,6 +68,8 @@
 	sprintf (ifreq.ifr_name, "%s%d",(const char*)options->device(),options->link());
 
 	PPPStat = & PPPInfo->stats;
+    PPPStat->p.ppp_ibytes = 0;
+    PPPStat->p.ppp_obytes = 0;
 	memset (LastPPPStat, 0, sizeof (LastPPPStat));
 	
 	get_command(ifreq.ifr_name);
@@ -88,7 +90,7 @@
 	    }
 	  }
 	  PPPStat->p.ppp_ibytes = 0;
-          PPPStat->p.ppp_obytes = 0;
+      PPPStat->p.ppp_obytes = 0;
 	} else if ( !_isUp ) {
 	  _isUp = true;
 	  killTimer( _retryId );
    
>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message