Date: Tue, 19 Dec 2017 14:11:59 +0100 From: Rodrigo Osorio <rodrigo@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org>, Alexey Dokuchaev <danfe@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r456527 - in head/databases: . postgis20 postgis21 postgis22 postgis23 postgis24 Message-ID: <3d5be087-2880-75c6-dd2c-c05e4569aab3@FreeBSD.org> In-Reply-To: <c3d69f46-8418-a1ef-f37b-c0a2b287a494@FreeBSD.org> References: <201712171125.vBHBPEGU053728@repo.freebsd.org> <20171217114147.GA19802@FreeBSD.org> <b2cc0815-523d-a1a2-e3a1-255b055f276c@freebsd.org> <20171218010012.GA76552@FreeBSD.org> <49742f49-87aa-9f6e-21ff-20ad5d1598cd@FreeBSD.org> <c91acd53-ba51-f1df-da55-8ce6b8a596ae@FreeBSD.org> <c3d69f46-8418-a1ef-f37b-c0a2b287a494@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/19/17 13:38, Mathieu Arnold wrote: > Le 18/12/2017 à 15:07, Mathieu Arnold a écrit : >> Le 18/12/2017 à 10:15, Rodrigo Osorio a écrit : >>> On 12/18/17 02:00, Alexey Dokuchaev wrote: >>>> On Sun, Dec 17, 2017 at 01:25:43PM +0100, Rodrigo Osorio wrote: >>>>> On 12/17/17 12:41, Alexey Dokuchaev wrote: >>>>>> On Sun, Dec 17, 2017 at 11:25:14AM +0000, Rodrigo Osorio wrote: >>>>>>> New Revision: 456527 >>>>>>> URL: https://svnweb.freebsd.org/changeset/ports/456527 >>>>>>> >>>>>>> Log: >>>>>>> Add new port postgis24 for v2.4.x >>>>>>> >>>>>>> Added: >>>>>>> head/databases/postgis24/ >>>>>>> head/databases/postgis24/Makefile (contents, props changed) >>>>>>> head/databases/postgis24/distinfo (contents, props changed) >>>>>>> head/databases/postgis24/pkg-descr (contents, props changed) >>>>>>> head/databases/postgis24/pkg-install (contents, props changed) >>>>>>> head/databases/postgis24/pkg-plist (contents, props changed) >>>>>> Looks like it should've been repocopied, not added as a new port. >>>>>> Can you explain why this wasn't done? >>>>> I don't get your question, do you see any issue regarding postgis24 >>>>> port? >>>> I have an issue not with the port per se, but with the way it was >>>> carried >>>> out (added to the collection). Please read Section 19.4* of the Ports >>>> Committer's Guide, albeit I'm surprised that your mentor did not tell >>>> you >>>> about it earlier. >>> Now I understand... >>> >>> To clarify my mentor instruct me about the procedure but it was a long >>> time ago. >>> I don't do this kind of commit so often, and this is probably my mistake. >> Now that this is all clarified and you know what to do, please remove >> the postgis24 port you added, and add it back using the proper procedure. > > Ping ? > > Mathieu, To be sure to do it once I submit the final fix as a review yesterday : https://reviews.freebsd.org/D13533. I notify danfe about it but has no feedback so I will commit the changes regards - rodrigo
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3d5be087-2880-75c6-dd2c-c05e4569aab3>