From owner-svn-src-head@freebsd.org Mon Feb 4 05:37:10 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0D48314BF38A; Mon, 4 Feb 2019 05:37:10 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: from mail-yw1-f52.google.com (mail-yw1-f52.google.com [209.85.161.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8FAB36E5F6; Mon, 4 Feb 2019 05:37:09 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: by mail-yw1-f52.google.com with SMTP id g194so5214002ywe.7; Sun, 03 Feb 2019 21:37:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9LWaY4w0XosidCoGvm68+CNrKmnY4PJgPLNXgHe0ako=; b=D9LDUOhUHBHmZgFberxRRtkRm8lgR1UaYX+76YFLaPzeKwvQiiRmi0wAjIc/W0UryD yIu8LUNK+Bkz+X9+OSvN0TuMdpIqTsC/UG72CGMq0oPGMCouyr9VrXa+93oyfgyrSqHH 0X2SSHiXiCyqAnHBJtIfHWhRgUkemyhC0xgpiQWg1OUKtlYteV+IW/I8ohhS0Ee7klhh ih/5c/J0nBOYEX2fO6VE8+dD3OygBQKUPDnMGJvxiwitSalCR+Q05tWI7AdlkBYaS5tf 2LpIpl+v5jp5p594fidswECWpCACh+s8a/dR5A4hreotH0+vguTcA2og7TgwwVcFZOQa JCYw== X-Gm-Message-State: AHQUAuaOfJzzIh3tC6cX59j3WJ+XBMcutH1l5cma/XZhJ3yKUm/ruHsF EACb1Jvog/LzerkDk0B8YeEBmPw57RsvbZiXXtZHe5DQ X-Google-Smtp-Source: AHgI3IZVT8oGuTdPvReba4WHKhn21TFNhJ+UeFNFw7Z0Qy43HFTlrDSJXLDWei5pUzflK2dCXrpRAR+LYnVBTxYyiJw= X-Received: by 2002:a81:5f07:: with SMTP id t7mr1152535ywb.320.1549258150342; Sun, 03 Feb 2019 21:29:10 -0800 (PST) MIME-Version: 1.0 References: <201902031246.x13CkRY5049231@repo.freebsd.org> In-Reply-To: <201902031246.x13CkRY5049231@repo.freebsd.org> From: Li-Wen Hsu Date: Mon, 4 Feb 2019 13:28:58 +0800 Message-ID: Subject: Re: svn commit: r343713 - in head/sys: amd64/conf arm64/conf To: Andrew Turner Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 8FAB36E5F6 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.94)[-0.938,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Feb 2019 05:37:10 -0000 On Sun, Feb 3, 2019 at 8:46 PM Andrew Turner wrote: > > Author: andrew > Date: Sun Feb 3 12:46:27 2019 > New Revision: 343713 > URL: https://svnweb.freebsd.org/changeset/base/343713 > > Log: > Enable COVERAGE and KCOV by default on arm64 and amd64. > > This allows userspace to trace the kernel using the coverage sanitizer > found in clang. It will also allow other coverage tools to be built as > modules and attach into the same framework. > > Sponsored by: DARPA, AFRL > > Modified: > head/sys/amd64/conf/GENERIC > head/sys/arm64/conf/GENERIC > > Modified: head/sys/amd64/conf/GENERIC > ============================================================================== > --- head/sys/amd64/conf/GENERIC Sun Feb 3 11:41:43 2019 (r343712) > +++ head/sys/amd64/conf/GENERIC Sun Feb 3 12:46:27 2019 (r343713) > @@ -102,8 +102,8 @@ options MALLOC_DEBUG_MAXZONES=8 # Separate malloc(9) > options VERBOSE_SYSINIT=0 # Support debug.verbose_sysinit, off by default > > # Kernel Sanitizers > -#options COVERAGE # Generic kernel coverage. Used by KCOV > -#options KCOV # Kernel Coverage Sanitizer > +options COVERAGE # Generic kernel coverage. Used by KCOV > +options KCOV # Kernel Coverage Sanitizer > # Warning: KUBSAN can result in a kernel too large for loader to load > #options KUBSAN # Kernel Undefined Behavior Sanitizer > > > Modified: head/sys/arm64/conf/GENERIC > ============================================================================== > --- head/sys/arm64/conf/GENERIC Sun Feb 3 11:41:43 2019 (r343712) > +++ head/sys/arm64/conf/GENERIC Sun Feb 3 12:46:27 2019 (r343713) > @@ -94,8 +94,8 @@ options USB_DEBUG # enable debug msgs > options VERBOSE_SYSINIT=0 # Support debug.verbose_sysinit, off by default > > # Kernel Sanitizers > -#options COVERAGE # Generic kernel coverage. Used by KCOV > -#options KCOV # Kernel Coverage Sanitizer > +options COVERAGE # Generic kernel coverage. Used by KCOV > +options KCOV # Kernel Coverage Sanitizer > # Warning: KUBSAN can result in a kernel too large for loader to load > #options KUBSAN # Kernel Undefined Behavior Sanitizer This breaks gcc build: https://ci.freebsd.org/job/FreeBSD-head-amd64-gcc/8781/console : x86_64-unknown-freebsd12.0-gcc: error: unrecognized command line option '-fsanitize-coverage=trace-pc,trace-cmp'; did you mean '-fsanitize-coverage=trace-pc'? We probably need to adjust arguments passed to gcc. Li-Wen