From nobody Thu Nov 27 00:44:29 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dGyPD12gZz6HvBb; Thu, 27 Nov 2025 00:44:32 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta003.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dGyPC5LSsz45L9; Thu, 27 Nov 2025 00:44:31 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4003b.ext.cloudfilter.net ([10.228.9.157]) by cmsmtp with ESMTPS id OJGivbMzeAPFJOQ7avCVWD; Thu, 27 Nov 2025 00:44:30 +0000 Received: from spqr.komquats.com ([70.66.136.217]) by cmsmtp with ESMTPSA id OQ7ZvP6rj24TSOQ7avsgfI; Thu, 27 Nov 2025 00:44:30 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=Ie+KmGqa c=1 sm=1 tr=0 ts=69279eee a=h7br+8Ma+Xn9xscxy5znUg==:117 a=h7br+8Ma+Xn9xscxy5znUg==:17 a=kj9zAlcOel0A:10 a=6UeiqGixMTsA:10 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=YxBL1-UpAAAA:8 a=iFOJyE4y5vjxbGPV8i8A:9 a=CjuIK1q_8ugA:10 a=LK5xJRSDVpKd5WXXoEvA:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy.cwsent.com [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 5C16CA7; Wed, 26 Nov 2025 16:44:29 -0800 (PST) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 2367C18D; Wed, 26 Nov 2025 16:44:29 -0800 (PST) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Warner Losh cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: ddec4209b10d - main - ipfilter: fix broken build In-reply-to: <692795d5.d406.41ba701c@gitrepo.freebsd.org> References: <692795d5.d406.41ba701c@gitrepo.freebsd.org> Comments: In-reply-to Warner Losh message dated "Thu, 27 Nov 2025 00:05:41 +0000." List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 26 Nov 2025 16:44:29 -0800 Message-Id: <20251127004429.2367C18D@slippy.cwsent.com> X-CMAE-Envelope: MS4xfLz+eyJmjj3a2NuGdptL/Ozxtwtkd2OZwCX5ErN+keDLQ25v4zJNbJkBX2mt9m0fi9hEBowaNHMXsTc79yVLTEkQnbjb8X7VkKrO+kqQ1xJLAXR5tcRR GW7r6R5l1Pti+rUbYWSjLNXZWhe8dlaMQEhv8v/ugGSC2oGvNXC/kRVUI40FRV4PooHpOIVGrUPA73jmytrSQ8iPxybV+wAq2OfycpvsuUeG9dEnKmM3Syi/ RYx02kq/gIjNzza13GEftojZbygLf4NU2kEZfaG3Hxh20RKWt82vQiaWb70TGW/lIJ1WhO0/afGG+PN1MlgSDN5Gx8n+9B1U0WLxKr4jrp4= X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4dGyPC5LSsz45L9 In message <692795d5.d406.41ba701c@gitrepo.freebsd.org>, Warner Losh writes: > The branch main has been updated by imp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=ddec4209b10d65ef19e1d1b884e1b876 > eab58c7d > > commit ddec4209b10d65ef19e1d1b884e1b876eab58c7d > Author: Warner Losh > AuthorDate: 2025-11-27 00:04:29 +0000 > Commit: Warner Losh > CommitDate: 2025-11-27 00:05:35 +0000 > > ipfilter: fix broken build > > Every commit earns me a dozen emails that LINT is broken. This should > stop that. > > Fixes: eda1756d0454f ipfilter: Verify frentry on entry into kernel > Sponsored by: Netflix Thank you. Sorry for the breakage. > --- > sys/netpfil/ipfilter/netinet/fil.c | 4 +--- > sys/netpfil/ipfilter/netinet/ip_nat.c | 3 --- > 2 files changed, 1 insertion(+), 6 deletions(-) > > diff --git a/sys/netpfil/ipfilter/netinet/fil.c b/sys/netpfil/ipfilter/netine > t/fil.c > index 0de5378322df..0c5e22517dc4 100644 > --- a/sys/netpfil/ipfilter/netinet/fil.c > +++ b/sys/netpfil/ipfilter/netinet/fil.c > @@ -4413,9 +4413,7 @@ frrequest(ipf_main_softc_t *softc, int unit, ioctlcmd_t > req, caddr_t data, > void *ptr, *uptr; > u_int *p, *pp; > frgroup_t *fg; > - char *group, *name; > - size_t v_fr_size, v_element_size; > - int v_rem_namelen, v_fr_toend; > + char *group; > > ptr = NULL; > fg = NULL; > diff --git a/sys/netpfil/ipfilter/netinet/ip_nat.c b/sys/netpfil/ipfilter/net > inet/ip_nat.c > index d83454185609..b8602db91820 100644 > --- a/sys/netpfil/ipfilter/netinet/ip_nat.c > +++ b/sys/netpfil/ipfilter/netinet/ip_nat.c > @@ -978,9 +978,6 @@ ipf_nat_ioctl(ipf_main_softc_t *softc, caddr_t data, ioct > lcmd_t cmd, > int interr_tbl[3] = { 60077, 60081, 60078 }; > ipnat_t *nat, *nt, *n; > ipnat_t natd; > - char *name; > - size_t v_in_size, v_element_size; > - int v_rem_namelen, v_in_toend; > SPL_INT(s); > > #if !SOLARIS && defined(_KERNEL) > -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e**(i*pi)+1=0