From owner-svn-src-all@freebsd.org Thu Jun 23 12:01:40 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4B5DFB73624; Thu, 23 Jun 2016 12:01:40 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mx1.sbone.de (bird.sbone.de [46.4.1.90]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 0DCA52FDF; Thu, 23 Jun 2016 12:01:39 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id D1E6F25D37C2; Thu, 23 Jun 2016 12:01:30 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id BD775D1F827; Thu, 23 Jun 2016 12:01:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id q0pnQXFj4MLF; Thu, 23 Jun 2016 12:01:27 +0000 (UTC) Received: from [192.168.124.1] (unknown [IPv6:fde9:577b:c1a9:4410:21bf:e4ab:2432:b9]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 0908AD1F825; Thu, 23 Jun 2016 11:59:26 +0000 (UTC) From: "Bjoern A. Zeeb" To: "Marko Zec" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r302099 - head/sys/netinet Date: Thu, 23 Jun 2016 11:59:24 +0000 Message-ID: <1875471F-E650-4A29-89A5-D60DAD926C9F@FreeBSD.org> In-Reply-To: <20160623101757.3e8022fe@x23> References: <201606230034.u5N0Y3Ea069103@repo.freebsd.org> <20160623101757.3e8022fe@x23> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Mailer: MailMate Trial (2.0BETAr6032) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2016 12:01:40 -0000 On 23 Jun 2016, at 8:17, Marko Zec wrote: > On Thu, 23 Jun 2016 00:34:03 +0000 > "Bjoern A. Zeeb" wrote: > >> Author: bz >> Date: Thu Jun 23 00:34:03 2016 >> New Revision: 302099 >> URL: https://svnweb.freebsd.org/changeset/base/302099 >> >> Log: >> Check the V_tcbinfo.ipi_count to hit 0 before doing the full TCP >> cleanup. That way timers can finish cleanly and we do not gamble with >> a DELAY(). >> Reviewed by: gnn, jtl >> Approved by: re (gjb) >> Obtained from: projects/vnet >> MFC after: 2 weeks >> Sponsored by: The FreeBSD Foundation >> Differential Revision: https://reviews.freebsd.org/D6923 > > As much as this change is welcome, it unnecesarily introduces a > mandatory 100 ms delay on each vnet teardown, which I already pointed > out in a comment to r301601 two weeks ago, which remained unanswered, sorry about that. While VNET teardown is a non-criticial slow path and the pause doesn’t really matter a lot (unless you need the resources to be freed) you actually made me go an “benchmark” this in terms of how often my test cases do run into the pause after your change. It was indeed very rare. > along with the question why a delay of 100 ms was introduced here, when > before r302099 the delay was only a single clock tick? And furthermore > the delay computation expresion here is not style(9) compliant... > > Hence, please rectify the above objections, perhaps by something like: Done. Thanks a lot! /bz