From owner-freebsd-testing@FreeBSD.ORG Fri Jan 10 00:25:09 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 629B5372 for ; Fri, 10 Jan 2014 00:25:09 +0000 (UTC) Received: from co9outboundpool.messaging.microsoft.com (co9ehsobe001.messaging.microsoft.com [207.46.163.24]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 2083E1F92 for ; Fri, 10 Jan 2014 00:25:08 +0000 (UTC) Received: from mail12-co9-R.bigfish.com (10.236.132.228) by CO9EHSOBE013.bigfish.com (10.236.130.76) with Microsoft SMTP Server id 14.1.225.22; Fri, 10 Jan 2014 00:09:57 +0000 Received: from mail12-co9 (localhost [127.0.0.1]) by mail12-co9-R.bigfish.com (Postfix) with ESMTP id E57503001E3; Fri, 10 Jan 2014 00:09:56 +0000 (UTC) X-Forefront-Antispam-Report: CIP:66.129.239.16; KIP:(null); UIP:(null); IPV:NLI; H:P-EMF02-SAC.jnpr.net; RD:none; EFVD:NLI X-SpamScore: 2 X-BigFish: VPS2(zz1432Izz1f42h208ch1ee6h1de0h1fdah2073h2146h1202h1e76h2189h1d1ah1d2ah1fc6h1082kzz1de097hz31h2a8h839hd25hf0ah1288h12a5h12a9h12bdh12e5h137ah139eh13b6h1441h14ddh1504h1537h162dh1631h1758h1898h18e1h1946h19b5h1ad9h1b0ah1b2fh1b88h224fh1fb3h1d0ch1d2eh1d3fh1de2h1dfeh1dffh1e23h1fe8h1ff5h2218h2216h226dh22d0h2327h2336h2381h2438h1155h) Received-SPF: softfail (mail12-co9: transitioning domain of juniper.net does not designate 66.129.239.16 as permitted sender) client-ip=66.129.239.16; envelope-from=sjg@juniper.net; helo=P-EMF02-SAC.jnpr.net ; SAC.jnpr.net ; Received: from mail12-co9 (localhost.localdomain [127.0.0.1]) by mail12-co9 (MessageSwitch) id 1389312594228544_28516; Fri, 10 Jan 2014 00:09:54 +0000 (UTC) Received: from CO9EHSMHS026.bigfish.com (unknown [10.236.132.237]) by mail12-co9.bigfish.com (Postfix) with ESMTP id 324B920005E; Fri, 10 Jan 2014 00:09:54 +0000 (UTC) Received: from P-EMF02-SAC.jnpr.net (66.129.239.16) by CO9EHSMHS026.bigfish.com (10.236.130.36) with Microsoft SMTP Server (TLS) id 14.16.227.3; Fri, 10 Jan 2014 00:09:53 +0000 Received: from magenta.juniper.net (172.17.27.123) by P-EMF02-SAC.jnpr.net (172.24.192.21) with Microsoft SMTP Server (TLS) id 14.3.146.0; Thu, 9 Jan 2014 16:09:53 -0800 Received: from chaos.jnpr.net (chaos.jnpr.net [172.24.29.229]) by magenta.juniper.net (8.11.3/8.11.3) with ESMTP id s0A09qL44428; Thu, 9 Jan 2014 16:09:52 -0800 (PST) (envelope-from sjg@juniper.net) Received: from chaos.jnpr.net (localhost [127.0.0.1]) by chaos.jnpr.net (Postfix) with ESMTP id 3F2BF5807E; Thu, 9 Jan 2014 16:09:52 -0800 (PST) To: Julio Merino Subject: Re: Fixing installation of Kyuafiles In-Reply-To: <20140109233402.GA8193@fbair.virtual.network> References: <20140109233402.GA8193@fbair.virtual.network> Comments: In-reply-to: Julio Merino message dated "Thu, 09 Jan 2014 18:34:02 -0500." From: "Simon J. Gerraty" X-Mailer: MH-E 7.82+cvs; nmh 1.3; GNU Emacs 22.3.1 Date: Thu, 9 Jan 2014 16:09:52 -0800 Message-ID: <20140110000952.3F2BF5807E@chaos.jnpr.net> MIME-Version: 1.0 Content-Type: text/plain X-OriginatorOrg: juniper.net X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% Cc: freebsd-testing@freebsd.org, sjg@juniper.net X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jan 2014 00:25:09 -0000 >The bin/sh and bin/test tests are broken because they cannot be run as root, >yet the testing machines are currently running stuff as root. This is easy >to fix by adding a require_user="unprivileged" property to the tests. > >I was going to fix this by adding manually-crafted Kyuafile files that do >the above in bin/sh/tests/ and bin/test/tests/ and setting KYUAFILE=yes in >the corresponding Makefile files... but unfortunately that does not work >with NO_CLEAN builds. is the issue limited to just those dirs? >The problem is that bsd.test.mk generates Kyuafile files in the obj directory >and setting KYUAFILE=yes means that make will _still_ see the Kyuafile in the >obj directory and not the one that just appeared in src. > >Does the attached patch seem reasonable to prevent this in the future? This seems a reasonable change.