From owner-freebsd-ports@FreeBSD.ORG Sun Nov 13 14:26:11 2005 Return-Path: X-Original-To: ports@freebsd.org Delivered-To: freebsd-ports@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B9EF616A41F; Sun, 13 Nov 2005 14:26:11 +0000 (GMT) (envelope-from lofi@freebsd.org) Received: from mail-in-01.arcor-online.net (mail-in-01.arcor-online.net [151.189.21.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4065243D53; Sun, 13 Nov 2005 14:26:10 +0000 (GMT) (envelope-from lofi@freebsd.org) Received: from mail-in-07-z2.arcor-online.net (mail-in-07-z2.arcor-online.net [151.189.8.19]) by mail-in-01.arcor-online.net (Postfix) with ESMTP id 55F6251BBD; Sun, 13 Nov 2005 15:26:09 +0100 (CET) Received: from mail-in-02.arcor-online.net (mail-in-02.arcor-online.net [151.189.21.42]) by mail-in-07-z2.arcor-online.net (Postfix) with ESMTP id 47F231A1A11; Sun, 13 Nov 2005 15:26:09 +0100 (CET) Received: from lofi.dyndns.org (dslb-084-061-133-171.pools.arcor-ip.net [84.61.133.171]) by mail-in-02.arcor-online.net (Postfix) with ESMTP id CFAAF7C5EF; Sun, 13 Nov 2005 15:26:08 +0100 (CET) Received: from kiste.my.domain (root@kiste.my.domain [192.168.8.4]) by lofi.dyndns.org (8.13.4/8.13.3) with ESMTP id jADEQ6Qg085439 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 13 Nov 2005 15:26:07 +0100 (CET) (envelope-from lofi@freebsd.org) Received: from kiste.my.domain (lofi@localhost [127.0.0.1]) by kiste.my.domain (8.13.4/8.13.1) with ESMTP id jADEQ6qh018678; Sun, 13 Nov 2005 15:26:06 +0100 (CET) (envelope-from lofi@freebsd.org) Received: from localhost (localhost [[UNIX: localhost]]) by kiste.my.domain (8.13.4/8.13.1/Submit) id jADEQ5Mt018677; Sun, 13 Nov 2005 15:26:05 +0100 (CET) (envelope-from lofi@freebsd.org) X-Authentication-Warning: kiste.my.domain: lofi set sender to lofi@freebsd.org using -f From: Michael Nottebrock To: freebsd-ports@freebsd.org Date: Sun, 13 Nov 2005 15:25:59 +0100 User-Agent: KMail/1.8.3 References: <200511130038.jAD0cgLb043746@sakura.ninth-nine.com> <20051113212402.bf0fe702.nork@FreeBSD.org> <20051113125046.GA44237@nagual.pp.ru> In-Reply-To: <20051113125046.GA44237@nagual.pp.ru> X-Face: =Ym$`&q\+S2X$4`X%x%6"L4>Y,$]<":'L%c9"#7#`2tb&E&wsN31on!N\)3BD[g<=?utf-8?q?=2EjnfV=5B=0A=093=23?=>XchLK,o; >bD>c:]^; :>0>vyZ.X[,63GW`&M>}nYnr]-Fp``,[[@lJ!QL|sfW!s)=?utf-8?q?A2!*=0A=09vNkB/=7CL-?=>&QdSbQg X-Virus-Scanned: by amavisd-new Cc: ports@freebsd.org, Norikatsu Shigemura Subject: Re: Integrated DEBUG related macros to WITH_DEBUG/WITHOUT_DEBUG X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Nov 2005 14:26:12 -0000 --nextPart2812799.dnY1idyRim Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Sunday, 13. November 2005 13:50, Andrey Chernov wrote: > On Sun, Nov 13, 2005 at 09:24:02PM +0900, Norikatsu Shigemura wrote: > > On Sun, 13 Nov 2005 15:01:58 +0300 > > > > Andrey Chernov wrote: > > > *DEBUG knob has different meaning from port to port and often not just > > > -g adding, but turns on internal port debugging output/checks. > > > It means that it should be turned on/off separately on per port basis. > > > I.e. WITH__DEBUG. > > > WITH__* style options also allows to add them all into > > > /etc/make.conf without creating name conflicts between the ports. > > > > I don't think so. There are 127ports supported DEBUG related > > knobs. Only 127ports, and there are some ports which we > > request with DEBUG related knobs at the most. > > > > 'WITH_DEBUG' is well known and global knob. This is POLA > > important. If you want to turn on/off per port, you can > > set following description in /etc/make.conf. This is ungy, > > sure. But it's casual. > > First of all, I don't see any sense to turn debug for all 127 ports at > once. For many years the only need I see - turn for one of them. So it > isn't "global knob" as you say. It is local per port knob and should not > affect other ports. Yes, that's my main gripe with it as well. It's at least imaginable that=20 people would want to set the same dependency trigger for every port they=20 install, like WITH_ARTS (although it's just as well imaginable that they on= ly=20 want it for one or two ports in particular, which we traditionally only=20 support very badly and ought to fix), but it's hardly imaginable that anybo= dy=20 would want every port they install to be built with debug symbols. > > .if ${.CURDIR} =3D=3D "/usr/ports/foo/bar" > > WITH_DEBUG=3D yes > > .endif > > .if ${.CURDIR} =3D=3D "/usr/ports/bar/foo" > > WITH_DEBUG=3D yes > > .endif So are you consciously trying to make using ports *more* complicated or hav= e=20 you just been using make(1) for so such a long time you forgot how long it= =20 took you to learn about using make conditionals and the .CURDIR variable? 8= =2D) =2D-=20 ,_, | Michael Nottebrock | lofi@freebsd.org (/^ ^\) | FreeBSD - The Power to Serve | http://www.freebsd.org \u/ | K Desktop Environment on FreeBSD | http://freebsd.kde.org --nextPart2812799.dnY1idyRim Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQBDd0z9Xhc68WspdLARAi/KAJ9aXsC/IKkr51BJZHUdKnO5tQUZ6QCgiWu8 rQkSxXTqCws5oH7T0LH0e6M= =JPJU -----END PGP SIGNATURE----- --nextPart2812799.dnY1idyRim--