From owner-freebsd-bugs@FreeBSD.ORG Tue Jul 22 17:34:21 2014 Return-Path: Delivered-To: freebsd-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7668DE44 for ; Tue, 22 Jul 2014 17:34:21 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5C7142FA1 for ; Tue, 22 Jul 2014 17:34:21 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.8/8.14.8) with ESMTP id s6MHYLUD047297 for ; Tue, 22 Jul 2014 17:34:21 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 192013] [xen] [pf] pf performance very bad in xen when tso enabled Date: Tue, 22 Jul 2014 17:34:21 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: des@FreeBSD.org X-Bugzilla-Status: In Discussion X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: des@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.isobsolete bug_status assigned_to attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2014 17:34:21 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D192013 Dag-Erling Sm=C3=B8rgrav changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144852|0 |1 is obsolete| | Status|Needs Triage |In Discussion Assignee|freebsd-bugs@FreeBSD.org |des@FreeBSD.org --- Comment #2 from Dag-Erling Sm=C3=B8rgrav --- Created attachment 144883 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D144883&action= =3Dedit More conservative patch When you say =E2=80=9CTSO is disabled=E2=80=9D, I assume you mean on the vi= rtual interface (xnN) in the guest? I'm not comfortable removing this block of code without a clear understandi= ng of why it's there. It looks to me like the intent is to ensure that all packets have a valid checksum before they enter pf. Are we certain that pf won't break in some subtle way if that assumption is violated? BTW, the patch does not remove the equivalent code in pf_check6_out(), but = that code is broken anyway (as the comment points out). A more conservative fix is to keep calculating the checksum before pf_test *unless* hardware checksum offloading is enabled. --=20 You are receiving this mail because: You are the assignee for the bug.=