From owner-freebsd-stable@freebsd.org Thu Feb 28 22:40:23 2019 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D2F62151C81B for ; Thu, 28 Feb 2019 22:40:22 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 3868E8D645 for ; Thu, 28 Feb 2019 22:40:22 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mailman.ysv.freebsd.org (Postfix) id EC582151C81A; Thu, 28 Feb 2019 22:40:21 +0000 (UTC) Delivered-To: stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C7607151C819 for ; Thu, 28 Feb 2019 22:40:21 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F3E58D641 for ; Thu, 28 Feb 2019 22:40:21 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x72f.google.com with SMTP id f196so13147368qke.10 for ; Thu, 28 Feb 2019 14:40:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=v6mNFjfGHnz1wy0PUFZAFcLoO3dbGy4qDz3tFAfAIu8=; b=zjcqOC7ScWncKVUlWtDrjjeGyK5k2+JpikwIY9O/bqWTZ+87q/ZX73mDs+pNmygPy5 OUSZ4L6GBdVEr495bBsJW36viuJun3VPloxCepviTWi4rmua5zdYB4OdsRcG6WtSihZ3 4pKcXokuCfrubIlHQ50n6NdDq7rlphsu71tTEF8q59be4tQK6YEDQNy6q0AtzmPTQCyY MzrzkEFelsNj40CEKj7HvfJ6Yzvhh5/FeSMKH8Zsv7SE6EeiA9x6pLf2sl6SPv+VA5Wx jv/HV6NMbSE4cjl5mQzHx0XzETcDr86v9RepspgfcymyoUm0LupJl1C7ib1S7c/Et+dk hyAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=v6mNFjfGHnz1wy0PUFZAFcLoO3dbGy4qDz3tFAfAIu8=; b=O/vQXOomYPdauCHYu26hxZn/LJ1bze+TN56qTEeTPm6Gsoc9JYJsFI7vsjwrwi06Cb 9IhFNks86MA/oGklZgINjKy+owA+8+6oF0pnnIe6LZ411Ey5LY9l094uVnU/wW5aWTEz IE+SOY6j3hW/yIXzhhivLqaAbhc9wCqd6z/SHCJ2MTe2IaaGDiH2XmmL6/mzXOR0UZhl 5W7XFM0nQHoiICosy40Z7glyPLbjdpLO60qrkeSwUtnQt+iXePkdMqvByM67DxxqFUJ3 vd/4oAz19n2CULflqJoj9yA/napwD7u6BUuK7kUTt8WPjAScJU1zsAlvZPhYuRZYj1tF J7Pw== X-Gm-Message-State: APjAAAUym/Jpum2ldcg+ovYmKtWp+pbkNB7UpzbHflwySsp9TqCsDsxl Kc2SBrR0Z0jafxYE6QZVFx1+0TNx8KY2p0Oe8Rxkrw== X-Google-Smtp-Source: APXvYqx6ewoIydW8oIW93l9L8/LiD9pAZ0kmxtL3Sivu++a6qcgbftHnjCS5vfKssj3I5xWeXN4WVAl3wXUF/whiveM= X-Received: by 2002:a37:a704:: with SMTP id q4mr1539782qke.245.1551393620477; Thu, 28 Feb 2019 14:40:20 -0800 (PST) MIME-Version: 1.0 References: <201902281659.x1SGxP7X057343@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201902281659.x1SGxP7X057343@pdx.rh.CN85.dnsmgr.net> From: Warner Losh Date: Thu, 28 Feb 2019 15:40:09 -0700 Message-ID: Subject: Re: FreeBSD 12.0 RELEASE i386 can not build a kernel? To: "Rodney W. Grimes" Cc: Ed Maste , Konstantin Belousov , stable@freebsd.org, Dimitry Andric X-Rspamd-Queue-Id: 4F3E58D641 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.99)[-0.985,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Feb 2019 22:40:23 -0000 On Thu, Feb 28, 2019 at 10:00 AM Rodney W. Grimes < freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > [ Charset UTF-8 unsupported, converting... ] > > On Thu, 28 Feb 2019 at 09:33, Rodney W. Grimes > > wrote: > > > > > > LD?=ld.lld in the right place(s)? > > > > Perhaps, I seem to recall some issue with that, but not the specifics. > > sys.mk already does a LD?=ld so by the time we try > to override it in the Makefile.i386 it is too late > as already defined. > > *sigh* > Yes, the problem is that ?= only works once. There's some gross things we can do, but they aren't worthwhile, imho. eg .if defined(KERNEL_LD_OVERRIDE) LD=${KERNEL_LD_OVERRIDE} .else LD=ld.lld .endif or other variations on that. We could do it without the .else clause and just add KERNEL_LD_OVERRIDE=ld.lld to GENERIC on i386 as a build-time override. This would give people a way out, but would violate POLA a little bit. Given the frequency of overriding LD=, it may be OK. People sophisticated enough to do that surely are sophisticated enough to read changes to the kernel config files. This wouldn't help everybody (especially those with custom kernel configs), but short of adding it to DEFAULTS, it's likely pushing the edge of how disruptive one can be in a stable branch. So there's a number of variations on this theme. I'm not convinced they are worthwhile for this issue because none are side-effect free, but it's certainly a solution space others can noodle through to see if they can find the "just so" mix of POLA and bug fixing. Warner