From owner-svn-src-user@FreeBSD.ORG Sun Feb 1 22:09:49 2009 Return-Path: <owner-svn-src-user@FreeBSD.ORG> Delivered-To: svn-src-user@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E47531065670 for <svn-src-user@FreeBSD.org>; Sun, 1 Feb 2009 22:09:49 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from pele.citylink.co.nz (pele.citylink.co.nz [202.8.44.226]) by mx1.freebsd.org (Postfix) with ESMTP id A77458FC1A for <svn-src-user@FreeBSD.org>; Sun, 1 Feb 2009 22:09:49 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) by pele.citylink.co.nz (Postfix) with ESMTP id 3EF0AFF79; Mon, 2 Feb 2009 10:37:53 +1300 (NZDT) X-Virus-Scanned: Debian amavisd-new at citylink.co.nz Received: from pele.citylink.co.nz ([127.0.0.1]) by localhost (pele.citylink.co.nz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id M6PtYgRfYCzj; Mon, 2 Feb 2009 10:37:49 +1300 (NZDT) Received: from citylink.fud.org.nz (unknown [202.8.44.45]) by pele.citylink.co.nz (Postfix) with ESMTP; Mon, 2 Feb 2009 10:37:49 +1300 (NZDT) Received: by citylink.fud.org.nz (Postfix, from userid 1001) id 34C9F1142A; Mon, 2 Feb 2009 10:37:49 +1300 (NZDT) Date: Sun, 1 Feb 2009 13:37:49 -0800 From: Andrew Thompson <thompsa@FreeBSD.org> To: "M. Warner Losh" <imp@bsdimp.com> Message-ID: <20090201213749.GJ32503@citylink.fud.org.nz> References: <200902010650.n116obU1045871@svn.freebsd.org> <20090201.142808.886478999.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090201.142808.886478999.imp@bsdimp.com> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: src-committers@FreeBSD.org, svn-src-user@FreeBSD.org Subject: Re: svn commit: r187978 - user/thompsa/usb/sys/dev/usb2/ethernet X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" <svn-src-user.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>, <mailto:svn-src-user-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/svn-src-user> List-Post: <mailto:svn-src-user@freebsd.org> List-Help: <mailto:svn-src-user-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>, <mailto:svn-src-user-request@freebsd.org?subject=subscribe> X-List-Received-Date: Sun, 01 Feb 2009 22:09:50 -0000 On Sun, Feb 01, 2009 at 02:28:08PM -0700, M. Warner Losh wrote: > In message: <200902010650.n116obU1045871@svn.freebsd.org> > Andrew Thompson <thompsa@FreeBSD.org> writes: > : + locked = mtx_owned(&sc->sc_mtx); > : + if (!locked) > : + AUE_LOCK(sc); > > You do know this is racy, right? Yea... It only get called unlocked during mii probe+attach so its fine. I havnt actaully checked if its ok to hold a mutex during mii_phy_probe() which would make this go away. Andrew