From owner-freebsd-arch Wed May 9 9:22:10 2001 Delivered-To: freebsd-arch@freebsd.org Received: from meow.osd.bsdi.com (meow.osd.bsdi.com [204.216.28.88]) by hub.freebsd.org (Postfix) with ESMTP id 958CC37B423; Wed, 9 May 2001 09:22:06 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: from laptop.baldwin.cx (john@jhb-laptop.osd.bsdi.com [204.216.28.241]) by meow.osd.bsdi.com (8.11.2/8.11.2) with ESMTP id f49GM2G52464; Wed, 9 May 2001 09:22:02 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: Date: Wed, 09 May 2001 09:21:08 -0700 (PDT) From: John Baldwin To: Robert Watson Subject: RE: Patch to eliminate struct pcred Cc: arch@FreeBSD.org Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 09-May-01 Robert Watson wrote: > > John, > > Thanks for your comments. As you point out, the srv4 exit change is > replicated from your kern_exit change of similar ilk. It might be nice to > revisit whatever rationale there was for breaking out the srv4 exit code, > and see if we can just rely on a wrapped exit1(), which is the approach > taken by the linuxulator. This would reduce code replication. Yes, it does need to be wrapped. I think it is unwrapped because we got it from NetBSD and that may be how they do things. *shrug* > I've likewise removed the intrace cached process flag, Thanks. Some comments: @@ -274,21 +275,31 @@ ... - (p->p_flag & P_TRACED) == 0) { + p->p_flag & P_TRACED) { ... It looks like you've inverted the sense of that test. What is the XXX: locking comment about here: @@ -296,25 +307,50 @@ + p->p_flag &= ~P_SUGID; /* XXX locking */ PROC_UNLOCK(p); The process is locked when that flag is cleared. Looks fine otherwise. -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message