From nobody Thu May 11 15:48:28 2023 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QHGWx1JT1z4BNcJ for ; Thu, 11 May 2023 15:48:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QHGWx0C9Rz4cJn for ; Thu, 11 May 2023 15:48:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1683820109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2QTYbEKCAQ9kzQXroIWjsr+bR35dEvhuIxccHGmdWGo=; b=hw/QPspADNGYO2+RL1Asj3PW4439zI4oL//nUWQfl1AIunB3Ps7PX0Iri+i8muNPLl+xWo rbhqw+V3waFANjtZ4U66yOg/lSEae1swNLuWEbPUo6TFquA7oaU/loNkVPCJ3SQDJSv8ia DoYx0BxP7Ncaua8p7HtbsXou0KhHUV/mqx8StCslBn0ZOjYhn4wGGrVhao0C2+AlL3jfYa +uqSbwVbf09mawd9lZAT4KeZHE5DHQFbvcYpPY51Chhai+fRVZEAMxi9ZJvhMhvCfp+2AB XOroA/O1HXz9oxiTe8oXkryIPxb2MaQ/aHscNF3phAbYfZ7CWyJB+slhOwCtVQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1683820109; a=rsa-sha256; cv=none; b=CEXS4GUVNlTUCHpzWNntrAEdNegGnRH2iW2RwWdc8bptI01a0X9MSq6U0BYNitiEzayqM+ uERddFgBjFMG5pvqHnAk4fN5cQ4MY7MPTo2dnE9DCYNZ3lEJiy+mt07kmuOovfhu7ybDsb Sh+mNFEHpLXwZbhsK3feOU7nVHwTyH6SCZUuOlRrTRE6nFtnz91NHeYjNfwxkcpR6C9tDD a4SpP0P1CmJ6NMBE14meVJHh6FuaGq51czhpdwZzciA2qYMvMGdCIMXoSfi8QHFYmGs1ia jWpK3W9uupOCmkKYJZT0BL9bj0l8nO1lzWSne5+DHBi1nmsHJIUzERIQGZInkQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QHGWw6NzYzyZk for ; Thu, 11 May 2023 15:48:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 34BFmSo2036389 for ; Thu, 11 May 2023 15:48:28 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 34BFmSh9036388 for net@FreeBSD.org; Thu, 11 May 2023 15:48:28 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 254596] if_bridge wants LRO turned off, if_vlan insists it remain on Date: Thu, 11 May 2023 15:48:28 +0000 X-Bugzilla-Reason: AssignedTo CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.2-RELEASE X-Bugzilla-Keywords: needs-patch, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: paul@redbarn.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? mfc-stable13? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D254596 --- Comment #6 from paul vixie --- (In reply to Ed Maste from comment #5) since it doesn't seem unreasonable to you, i'll do what you ask, but first i will test it. i think the patch is unreasonable and that it would be better to strike the= se two "if" statements than to containerize them to the non-bridge case. howev= er, what i'm actually proposing is less controversial in that it's unable to br= eak a working configuration. removing the LRO logic (those two if statements) c= ould indeed break working configurations. --=20 You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug.=