From owner-cvs-all Wed Sep 5 19: 9: 9 2001 Delivered-To: cvs-all@freebsd.org Received: from alpo.whistle.com (s206m1.whistle.com [207.76.206.1]) by hub.freebsd.org (Postfix) with ESMTP id 63F8937B407; Wed, 5 Sep 2001 19:09:02 -0700 (PDT) Received: from [10.1.10.118] ([10.1.10.118]) by alpo.whistle.com (8.9.1a/8.9.1) with ESMTP id TAA06855; Wed, 5 Sep 2001 19:06:25 -0700 (PDT) Mime-Version: 1.0 X-Sender: mark-ml@207.76.206.1 Message-Id: In-Reply-To: <200109051850.f85Io3o99434@freefall.freebsd.org> References: <200109051850.f85Io3o99434@freefall.freebsd.org> Date: Wed, 5 Sep 2001 19:07:09 -0700 To: Alexey Zelkin , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org From: Mark Peek Subject: Re: cvs commit: src/lib/libc/stdlib strfmon.c Makefile.inc Content-Type: text/plain; charset="us-ascii" Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG At 11:50 AM -0700 9/5/01, Alexey Zelkin wrote: >phantom 2001/09/05 11:50:02 PDT > > Modified files: > lib/libc/stdlib Makefile.inc > Added files: > lib/libc/stdlib strfmon.c > Log: > Add strfmon(3) implementation. It still contains few XXX's because I lost > my last version of this work due to HDD crash, but this version cleanly > passed all POSIX and SuSv2 tests. I am working on testing scripts which > should test this implementation against all locales and surely more fixes > will come soon. > > Reviewed by: ache, silence at -audit & -developers > > Revision Changes Path > 1.29 +4 -4 src/lib/libc/stdlib/Makefile.inc This broke my -current buildworld: cc -nostdinc -O -pipe -DLIBC_RCS -DSYSLIBC_RCS -I/usr/src/lib/libc/include -I/usr/src/lib/libc/../../include -DLIBC_MAJOR=5 -D__DBINTERFACE_PRIVATE -DINET6 -I/usr/obj/usr/src/lib/libc -DPOSIX_MISTAKE -I/usr/src/lib/libc/../libc/locale -DBROKEN_DES -DPORTMAP -DDES_BUILTIN -DYP -DHESIOD -I/usr/obj/usr/src/i386/usr/include -c /usr/src/lib/libc/../libc/stdlib/strfmon.c -o strfmon.o /usr/src/lib/libc/../libc/stdlib/strfmon.c: In function `strfmon': /usr/src/lib/libc/../libc/stdlib/strfmon.c:302: syntax error before `else' /usr/src/lib/libc/../libc/stdlib/strfmon.c:233: label `end_error' used but not defined /usr/src/lib/libc/../libc/stdlib/strfmon.c:162: label `format_error' used but not defined /usr/src/lib/libc/../libc/stdlib/strfmon.c:144: label `e2big_error' used but not defined Below is a patch that matches the code put up for review at http://phantom.cris.net/~phantom/strfmon04.tgz Mark Index: lib/libc/stdlib/strfmon.c =================================================================== RCS file: /cvs/freebsd/src/lib/libc/stdlib/strfmon.c,v retrieving revision 1.1 diff -u -u -r1.1 strfmon.c --- lib/libc/stdlib/strfmon.c 2001/09/05 18:50:02 1.1 +++ lib/libc/stdlib/strfmon.c 2001/09/06 01:50:12 @@ -297,10 +297,11 @@ PRINT(' '); if (sign_posn == 0) { - if (flags & IS_NEGATIVE) + if (flags & IS_NEGATIVE) { PRINT('('); - else + } else { PRINT(' '); + } } if (cs_precedes == 1) { To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message