From owner-freebsd-smp Thu Mar 14 12: 1:27 2002 Delivered-To: freebsd-smp@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id BAB0337B417; Thu, 14 Mar 2002 12:01:22 -0800 (PST) Received: from localhost (arr@localhost) by fledge.watson.org (8.11.6/8.11.6) with SMTP id g2EK1HN00341; Thu, 14 Mar 2002 15:01:17 -0500 (EST) (envelope-from arr@FreeBSD.org) X-Authentication-Warning: fledge.watson.org: arr owned process doing -bs Date: Thu, 14 Mar 2002 15:01:16 -0500 (EST) From: "Andrew R. Reiter" X-Sender: arr@fledge.watson.org To: Jake Burkholder Cc: "Andrew R. Reiter" , freebsd-smp@FreeBSD.org Subject: Re: Patch to lock down modules In-Reply-To: <20020314134359.C52298@locore.ca> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-smp@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Thu, 14 Mar 2002, Jake Burkholder wrote: :> :Can you explain the wierd logic that was added to linker_file_unload? :> :> Ugh, yes, this is kinda ugly. Essentially this is a result of hacking :> this back and forth between where we should be holding SLOCK over. This :> is exactly what I wanted to discuss this b/c prior to making this change, :> I had a much more simple strategy here (but was dropped due to changes to :> a better strategy for kern_module). We discussed before about possibly :> having two sets of lookup functions -- internal and external -- perhaps :> this is a better solution? : :Hmm, I'll have to look at it more closely. : :> :> :Thanks, :> :Jake I uploaded a new patch (tested somewhat) to: http://people.freebsd.org/~arr/modlock.diff this takes care of 2 of the 3 issues you brought up -- but, I'd enjoy inspection of the atomic set and addcalls I used. I'll relook at the 3rd issue (ugliness in kern_linker) and see what I can figure out if I don't hear from you. Thanks, Andrew -- Andrew R. Reiter arr@watson.org arr@FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-smp" in the body of the message