From nobody Wed Aug 5 15:16:15 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hFYsD0gFhz6nQVF for ; Wed, 05 Aug 2026 15:16:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hFYsC5MrGz3vLZ for ; Wed, 05 Aug 2026 15:16:15 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785942975; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1Zf4p02tsyHNE+058OkVCMBbutvGCwtuwIoftfYYLTQ=; b=oMeiReSJ3/fZMCRa9UWsRIEW4AniUf2ofHNaDzK2S6ZDsFIdsyBiVdvQG61a4uAcAaHEm8 icsLGh8M74KnfHiVhi86atHbH/oelwQ1RHh/yPzbo9I+vkvicvlO6a6IIEftSTzkigSIZl SyL1ypZjPM2+59v46ilINygGncwiMMO483V1wru3Z329hdyXeiHg+RecmTKtSUFj6p7EBk fPKFLYxYiZ4RwpZFXDJZWwuit23m8mgCDTmY9mBLLaNxm/pKzLNZjoHB14PE8edmUy3HTT 4KH16ra/pT4W/F+Iy1JhxjhOsKhYq3MbAIqXMQkuV9Jvi+nkHp0gRhWif9b5hA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785942975; a=rsa-sha256; cv=none; b=L1QjzjqYCSkth8SJXfvT4+59YSrvZKMU1w8FHFjCAASUGchtzDqOlVAyMPWHNqhIaLuwy/ njd3uqAPhqhvYcTY5vYD5LMrhdTbid8xQSG2lmcSeQRiE9OWxWCTMmrrmnm0H6kjRAnkXg PU/SyiRcU5V6+EQrsskvx+JI6AN/1XGe655lulFH280UlxPSRp5fqUG60aprEcJE6mxVv1 A7Psky7iVFjv+lNWcivCix3vn6S/KVjAPeUHnlCV7dOVB3UseuqmpCBufrOmeikmzIpbLd qYIT/dErk8bEt24VGDsbP2VLPMTqUobAiLW1Y3j1YD9l8D2jR///N01ppDcHIA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785942975; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1Zf4p02tsyHNE+058OkVCMBbutvGCwtuwIoftfYYLTQ=; b=n3IB7my4YZgXpqpNba7ciNSpZNVHlzIubAcmZeet8Iz8JvtUkppHT0wBwxR5nxZze7sFBn vu/pV5PI9CkrO8eU0CQapS6x4tNlPTVHYXFAlMfWwXkQaDqc65CfKS8MYpyhpoo37jiyBQ 3pJvlXEJWx8zatkrU1cyUNcBnairnJyJN++AXwTHzKsm4VaEQUWG5G2rzfFntSv5S9SW6S VzdCUgAL8UgZF/Cs0j8IrnE+l4CSWISLfh1ed/QXFe623qLEDJx5bSXQtyd09LF5wHRSb6 0cKuFBqF24vOFM5vuk3ebnqL05SJTgy5TlZOjLs5RYrrPTwXo2OKOjc4cvLv7A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hFYsC4MQPzgHT for ; Wed, 05 Aug 2026 15:16:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 45137 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 05 Aug 2026 15:16:15 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 1802e8fa3364 - stable/14 - netinet6/nd6: Sprinkle missing prefix refcounting List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 1802e8fa3364dd6c744e0edb2e5815244938032d Auto-Submitted: auto-generated Date: Wed, 05 Aug 2026 15:16:15 +0000 Message-Id: <6a7353bf.45137.756e9d5c@gitrepo.freebsd.org> The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=1802e8fa3364dd6c744e0edb2e5815244938032d commit 1802e8fa3364dd6c744e0edb2e5815244938032d Author: Mark Johnston AuthorDate: 2026-07-24 20:05:06 +0000 Commit: Mark Johnston CommitDate: 2026-08-05 15:15:14 +0000 netinet6/nd6: Sprinkle missing prefix refcounting When we drop the prefix lock to call nd6_prefix_offlink() or nd6_prefix_onlink(), make sure to keep the correpsonding prefix structure alive. It is possible for a concurrent nd6_timer() to expire the prefix while the lock is dropped. Reported by: Maik Muench of Secfault Security Reviewed by: pouria, zlei MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D58423 (cherry picked from commit 76ca489e0f147e9bd90408ea562087e84ed6f479) --- sys/netinet6/nd6_rtr.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sys/netinet6/nd6_rtr.c b/sys/netinet6/nd6_rtr.c index eeecbe2c70c4..d8395bc711c4 100644 --- a/sys/netinet6/nd6_rtr.c +++ b/sys/netinet6/nd6_rtr.c @@ -1888,6 +1888,7 @@ restart: flags = pr->ndpr_stateflags & (NDPRF_DETACHED | NDPRF_ONLINK); if (flags == 0 || flags == (NDPRF_DETACHED | NDPRF_ONLINK)) { genid = V_nd6_list_genid; + nd6_prefix_ref(pr); ND6_RUNLOCK(); if ((flags & NDPRF_ONLINK) != 0 && (e = nd6_prefix_offlink(pr)) != 0) { @@ -1906,6 +1907,7 @@ restart: &pr->ndpr_prefix.sin6_addr), pr->ndpr_plen, e)); } + nd6_prefix_rele(pr); ND6_RLOCK(); if (genid != V_nd6_list_genid) goto restart; @@ -2168,6 +2170,7 @@ restart: int e; genid = V_nd6_list_genid; + nd6_prefix_ref(opr); ND6_RUNLOCK(); if ((e = nd6_prefix_onlink(opr)) != 0) { nd6log((LOG_ERR, @@ -2179,6 +2182,7 @@ restart: if_name(opr->ndpr_ifp), e)); } else a_failure = 0; + nd6_prefix_rele(opr); ND6_RLOCK(); if (genid != V_nd6_list_genid) goto restart;