From owner-svn-src-all@freebsd.org Thu Mar 28 07:25:37 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 04C8A154E784 for ; Thu, 28 Mar 2019 07:25:37 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: from mail-yw1-xc33.google.com (mail-yw1-xc33.google.com [IPv6:2607:f8b0:4864:20::c33]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 82BB889020 for ; Thu, 28 Mar 2019 07:25:36 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: by mail-yw1-xc33.google.com with SMTP id u197so14489694ywf.3 for ; Thu, 28 Mar 2019 00:25:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Eifs04LE3UCVd/dtXNEjMniPgZyjLkvYH0NHulGa8cA=; b=QrCtPKxnsBPN3/N1wOnvCON1E/RvdgYudekfLR+18xFPRIQtH50YGhUO7mptATJqWs 8Hb4a+f+/u21v2em2YCpcltd0uv20siQbqAp/IGaMXzpr97dWNHXZU+vkHboq81ygc+W KgmjsCkVimL//Ipxg7T+KRRE7fYusOjZsnHa5+WptkW+rzRlLiiNO17HI0ldrKzMjq2L nQ4oCwJL0uGepPfZncXseCKiA0AIijpcPYAyvqP2ryAcDEpnmTvPe7pBj6M2I3WqO0ZX cxe47WaS8QkaIJluNHIlwytNZiKAqv3ayUSBeeZJexOQbd4QvFd+DVAXBkfE6CB11mSn vIMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Eifs04LE3UCVd/dtXNEjMniPgZyjLkvYH0NHulGa8cA=; b=RexY2t3nKrKbnB9QAoRY7tM6W7O/3hDqyO2ZHYMSKteA5AmvNeqHRMcYn9TRdiV8bE 0jtYDWnh1gLO3/tWC0wsY4jiNK4HlVKe/IFkn00c+ssm+Hh4aHmQaFXL2GF7VWFWnUdE v5GpJXvxAstQrXYgSFDXyIv3QYifD6L98zCJJWpFqWi2Ar+NQXmXTozRGi7mA/ePZ7a6 Tq5F3FPktqXk1H8MSDwnTadlAO16Q+v2pvm/lqiS4VPN+q12qgTaZGxQiKCmvgX7njH+ /UsfKzyyBXHPLgMko4Mq0gYMVZhkIl2GsNcIi5zL7I7Y7aBvMpWm7pMILqldozN9S176 wpgQ== X-Gm-Message-State: APjAAAVEgraGYkiYXaouBEBkLf8/BUXj0/uj0OkH2xoX2QvULl+0eW6F JX3aQoxylVDrE50vSanNPz/yIVUv4hghBAI5dEDPVg== X-Google-Smtp-Source: APXvYqy/nTKmJo+7fHQN7BbFOEFNTHPqusjEYm3mNEQdF3aGZ9DCaVQkBNNl5tXijepE4LDDvhwFZMJPORp0cc/uijY= X-Received: by 2002:a81:8583:: with SMTP id v125mr33775235ywf.79.1553757935705; Thu, 28 Mar 2019 00:25:35 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:1688:0:0:0:0:0 with HTTP; Thu, 28 Mar 2019 00:25:35 -0700 (PDT) In-Reply-To: <201903280212.x2S2CXoG000730@repo.freebsd.org> References: <201903280212.x2S2CXoG000730@repo.freebsd.org> From: Oliver Pinter Date: Thu, 28 Mar 2019 08:25:35 +0100 Message-ID: Subject: Re: svn commit: r345625 - in head: contrib/elftoolchain/readelf lib/libc lib/libthr libexec/rtld-elf sys/sys To: Ed Maste Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" X-Rspamd-Queue-Id: 82BB889020 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.977,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Mar 2019 07:25:37 -0000 On Thursday, March 28, 2019, Ed Maste wrote: > Author: emaste > Date: Thu Mar 28 02:12:32 2019 > New Revision: 345625 > URL: https://svnweb.freebsd.org/changeset/base/345625 > > Log: > revert r341429 "disable BIND_NOW in libc, libthr, and rtld" > > r345620 by kib@ fixed the rtld issue that caused a crash at startup > during resolution of libc's ifuncs with BIND_NOW. > > PR: 233333 > Sponsored by: The FreeBSD Foundation > > Modified: > head/contrib/elftoolchain/readelf/readelf.c > head/lib/libc/Makefile > head/lib/libthr/Makefile > head/libexec/rtld-elf/Makefile > head/sys/sys/elf_common.h > > Modified: head/contrib/elftoolchain/readelf/readelf.c > ============================================================ > ================== > --- head/contrib/elftoolchain/readelf/readelf.c Thu Mar 28 01:12:44 2019 > (r345624) > +++ head/contrib/elftoolchain/readelf/readelf.c Thu Mar 28 02:12:32 2019 > (r345625) > @@ -3490,6 +3490,7 @@ dump_notes(struct readelf *re) > > static struct flag_desc note_feature_ctl_flags[] = { > { NT_FREEBSD_FCTL_ASLR_DISABLE, "ASLR_DISABLE" }, > + { NT_FREEBSD_FCTL_IMPLIED_MAX_PROT, "IMPLIED_MAX_PROT" }, > { 0, NULL } > }; > > Seems like this and the other hunk belongs to a different patch. > > Modified: head/lib/libc/Makefile > ============================================================ > ================== > --- head/lib/libc/Makefile Thu Mar 28 01:12:44 2019 (r345624) > +++ head/lib/libc/Makefile Thu Mar 28 02:12:32 2019 (r345625) > @@ -6,8 +6,6 @@ SHLIBDIR?= /lib > > .include > > -# BIND_NOW in libc results in segfault at startup (PR 233333) > -MK_BIND_NOW= no > # Force building of libc_pic.a > MK_TOOLCHAIN= yes > > > Modified: head/lib/libthr/Makefile > ============================================================ > ================== > --- head/lib/libthr/Makefile Thu Mar 28 01:12:44 2019 (r345624) > +++ head/lib/libthr/Makefile Thu Mar 28 02:12:32 2019 (r345625) > @@ -9,7 +9,6 @@ PACKAGE= clibs > SHLIBDIR?= /lib > > .include > -MK_BIND_NOW= no > MK_SSP= no > > LIB=thr > > Modified: head/libexec/rtld-elf/Makefile > ============================================================ > ================== > --- head/libexec/rtld-elf/Makefile Thu Mar 28 01:12:44 2019 > (r345624) > +++ head/libexec/rtld-elf/Makefile Thu Mar 28 02:12:32 2019 > (r345625) > @@ -6,7 +6,6 @@ > > .include > PACKAGE= clibs > -MK_BIND_NOW= no > MK_PIE= no # Always position independent using local rules > MK_SSP= no > > > Modified: head/sys/sys/elf_common.h > ============================================================ > ================== > --- head/sys/sys/elf_common.h Thu Mar 28 01:12:44 2019 (r345624) > +++ head/sys/sys/elf_common.h Thu Mar 28 02:12:32 2019 (r345625) > @@ -763,7 +763,8 @@ typedef struct { > #define NT_FREEBSD_FEATURE_CTL 4 > > /* NT_FREEBSD_FEATURE_CTL desc[0] bits */ > -#define NT_FREEBSD_FCTL_ASLR_DISABLE 0x00000001 > +#define NT_FREEBSD_FCTL_ASLR_DISABLE 0x00000001 > +#define NT_FREEBSD_FCTL_IMPLIED_MAX_PROT 0x00000002 > > /* Values for n_type. Used in core files. */ > #define NT_PRSTATUS 1 /* Process status. */ > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" >