From owner-svn-src-head@freebsd.org Thu Nov 12 17:10:55 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 78975A2C525; Thu, 12 Nov 2015 17:10:55 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E6FBF1CD4; Thu, 12 Nov 2015 17:10:54 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id tACHAkNo026817 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Thu, 12 Nov 2015 19:10:47 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua tACHAkNo026817 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id tACHAkxx026816; Thu, 12 Nov 2015 19:10:46 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 12 Nov 2015 19:10:46 +0200 From: Konstantin Belousov To: "Bjoern A. Zeeb" Cc: Randall Stewart , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r290714 - in head/sys/tests: callout_test framework Message-ID: <20151112171046.GN2257@kib.kiev.ua> References: <201511121031.tACAVEMb079802@repo.freebsd.org> <71CD11C2-1A0F-48B3-B9A9-B025676A887C@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <71CD11C2-1A0F-48B3-B9A9-B025676A887C@FreeBSD.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Nov 2015 17:10:55 -0000 On Thu, Nov 12, 2015 at 05:01:39PM +0000, Bjoern A. Zeeb wrote: > > > On 12 Nov 2015, at 10:31 , Randall Stewart wrote: > > > > Author: rrs > > Date: Thu Nov 12 10:31:14 2015 > > New Revision: 290714 > > URL: https://svnweb.freebsd.org/changeset/base/290714 > > > > Log: > > Style 9 changes. > > MFC after: 1 Month > > > > Modified: > > head/sys/tests/callout_test/callout_test.c > > head/sys/tests/framework/kern_testfrwk.c > > > I am just replying to the last commit given despite the efforts of people it still fails on PC98: > > /scratch/tmp/bz/head.svn/sys/modules/tests/callout_test/../../../tests/callout_test/callout_test.c:52:9: error: 'cpu_spinwait' macro redefined [-Werror,-Wmacro-redefined] > #define cpu_spinwait() > ^ > ./i386/cpu.h:50:9: note: previous definition is here > #define cpu_spinwait() ia32_pause() > ^ > 1 error generated. > --- callout_test.o --- > *** [callout_test.o] Error code 1 > > bmake: stopped in /scratch/tmp/bz/head.svn/sys/modules/tests/callout_test > Which version did you checked out ? I removed the redefinition of the cpu_spinwait() for UP in r290707, and it was not reverted.