From owner-freebsd-embedded@FreeBSD.ORG  Mon Jul  2 13:47:42 2007
Return-Path: <owner-freebsd-embedded@FreeBSD.ORG>
X-Original-To: freebsd-embedded@freebsd.org
Delivered-To: freebsd-embedded@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id C2E2F16A468;
	Mon,  2 Jul 2007 13:47:42 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 727D713C44C;
	Mon,  2 Jul 2007 13:47:42 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.13.8/8.13.4) with ESMTP id l62Dkcr8014425;
	Mon, 2 Jul 2007 07:46:39 -0600 (MDT) (envelope-from imp@bsdimp.com)
Date: Mon, 02 Jul 2007 07:47:21 -0600 (MDT)
Message-Id: <20070702.074721.148284252.imp@bsdimp.com>
To: henrik@brixandersen.dk
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20070702084757.GA8274@tirith.brixandersen.dk>
References: <20070701233235.GA875@tirith.brixandersen.dk>
	<20070701.190135.-1435633623.imp@bsdimp.com>
	<20070702084757.GA8274@tirith.brixandersen.dk>
X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0
	(harmony.bsdimp.com [127.0.0.1]);
	Mon, 02 Jul 2007 07:46:39 -0600 (MDT)
Cc: freebsd-embedded@freebsd.org, bug-followup@freebsd.org
Subject: Re: bin/11420 [nanobsd] Build failure on RELENG_6 
X-BeenThere: freebsd-embedded@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Dedicated and Embedded Systems <freebsd-embedded.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-embedded>, 
	<mailto:freebsd-embedded-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-embedded>
List-Post: <mailto:freebsd-embedded@freebsd.org>
List-Help: <mailto:freebsd-embedded-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-embedded>, 
	<mailto:freebsd-embedded-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Jul 2007 13:47:42 -0000

In message: <20070702084757.GA8274@tirith.brixandersen.dk>
            Henrik Brix Andersen <henrik@brixandersen.dk> writes:
: On Sun, Jul 01, 2007 at 07:01:35PM -0600, M. Warner Losh wrote:
: > In message: <20070701233235.GA875@tirith.brixandersen.dk>
: >             Henrik Brix Andersen <henrik@brixandersen.dk> writes:
: ...
: > : [1]: http://www.freebsd.org/cgi/query-pr.cgi?pr=114200
: > 
: > This patch is incorrect.
: > 
: > +.if !defined(NO_INSTALLLIB)
: > 
: > should be
: > 
: > +.if ${MK_INSTALLIB} != "no"
: 
: Oh - thanks for catching this. I guess the same change should be done
: in lib/ncurses/ncurses/Makefile, then?

I belive so.  I've CC'd ru@ to make sure.

Warner

: Here's an updated patch:
: 
: --- usr.bin/lex/lib/Makefile.orig	2007-07-02 01:06:20.000000000 +0200
: +++ usr.bin/lex/lib/Makefile	2007-07-02 10:41:47.000000000 +0200
: @@ -6,8 +6,10 @@
:  SRCS=   libmain.c libyywrap.c
:  NO_PIC=
:  
: +.if ${MK_INSTALLLIB} != "no"
:  LINKS=  ${LIBDIR}/libln.a ${LIBDIR}/libl.a
:  LINKS+=	${LIBDIR}/libln.a ${LIBDIR}/libfl.a
: +.endif
:  
:  .if ${MK_PROFILE} != "no"
:  LINKS+= ${LIBDIR}/libln_p.a ${LIBDIR}/libl_p.a
: 
: 
: And for good meassure - a patch for lib/ncurses/ncurses/Makefile:
: 
: --- lib/ncurses/ncurses/Makefile.orig	2007-07-02 10:43:17.000000000 +0200
: +++ lib/ncurses/ncurses/Makefile	2007-07-02 10:44:14.000000000 +0200
: @@ -280,7 +280,7 @@
:  INCSLINKS=	curses.h ${INCLUDEDIR}/ncurses.h
:  .endif
:  
: -.if !defined(NO_INSTALLLIB)
: +.if ${MK_INSTALLLIB} != "no"
:  SYMLINKS+=	libncurses${LIB_SUFFIX}.a ${LIBDIR}/libcurses${LIB_SUFFIX}.a
:  SYMLINKS+=	libncurses${LIB_SUFFIX}.a ${LIBDIR}/libtermcap${LIB_SUFFIX}.a
:  SYMLINKS+=	libncurses${LIB_SUFFIX}.a ${LIBDIR}/libtermlib${LIB_SUFFIX}.a
: 
: 
: -- 
: Henrik Brix Andersen <henrik@brixandersen.dk>