From owner-svn-src-all@freebsd.org Tue Oct 27 01:25:24 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 15B768EC2; Tue, 27 Oct 2015 01:25:24 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [64.62.153.212]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "anubis.delphij.net", Issuer "StartCom Class 1 Primary Intermediate Server CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 824231FAC; Tue, 27 Oct 2015 01:25:22 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from zeta.ixsystems.com (unknown [12.229.62.2]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by anubis.delphij.net (Postfix) with ESMTPSA id 6AFEA2A16A; Mon, 26 Oct 2015 18:25:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=delphij.net; s=anubis; t=1445909121; x=1445923521; bh=DlOFPV7hYDLDnDd8iB6Fgq6chXaeHU9USdKHkxFfwBY=; h=Reply-To:Subject:References:To:Cc:From:Date:In-Reply-To; b=Q7Kztpn4YoMnNvC4RAsghCDq1Evc8uyMXIuYw+NeW736Mejh3BCBbT5AJGWmMGVEw cXHBWm+moP/HH2ydd3NEIcMCB9cTzYezOUxb1NpRaLFm9xGEVtFQoRS5lJzJAminmM Lv15qnVyLsv1lrj2hQJqcC1zMID1R+sNvCH2uZGo= Reply-To: d@delphij.net Subject: Re: svn commit: r289269 - head/usr.sbin/tzsetup References: <201510132255.t9DMtHpe000697@repo.freebsd.org> <562EC8D6.6050609@FreeBSD.org> To: Adrian Chadd , Bryan Drewery Cc: Xin LI , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" From: Xin Li Organization: The FreeBSD Project Message-ID: <562ED280.2030307@delphij.net> Date: Mon, 26 Oct 2015 18:25:20 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4fHAqkBBRaXfFUoEPB2lxEwUlX5kUpdr6" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Oct 2015 01:25:24 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4fHAqkBBRaXfFUoEPB2lxEwUlX5kUpdr6 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/26/15 18:07, Adrian Chadd wrote: > Hi, >=20 > Please don't break non-root builds. I may get stabby. >=20 > :) Will revert now. > -adrian >=20 >=20 > On 26 October 2015 at 19:44, Bryan Drewery wrote= : >> On 10/13/2015 3:55 PM, Xin LI wrote: >>> Author: delphij >>> Date: Tue Oct 13 22:55:17 2015 >>> New Revision: 289269 >>> URL: https://svnweb.freebsd.org/changeset/base/289269 >>> >>> Log: >>> Use chroot(2) instead of using prefixes for files. >>> >>> Previously, the code prefixes the chroot path to actual file paths = to >>> simulate the effect. This, however, will not work for tzset(3) whi= ch >>> expects the current system have a working set of timezone data file= s, >>> and that is not always the case. >>> >>> This changeset simplifies the handling of paths and use an actual >>> chroot(2) call to implement the effect. >>> >>> PR: bin/197313 >>> MFC after: 2 weeks >>> >>> Modified: >>> head/usr.sbin/tzsetup/tzsetup.c >>> >>> Modified: head/usr.sbin/tzsetup/tzsetup.c >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>> --- head/usr.sbin/tzsetup/tzsetup.c Tue Oct 13 21:34:54 2015 = (r289268) >>> +++ head/usr.sbin/tzsetup/tzsetup.c Tue Oct 13 22:55:17 2015 = (r289269) >>> @@ -40,6 +40,7 @@ __FBSDID("$FreeBSD$"); >>> #include >>> #include >>> #include >>> +#include >>> #include >>> #include >>> >>> @@ -944,23 +945,18 @@ main(int argc, char **argv) >>> if (argc - optind > 1) >>> usage(); >>> >>> - if (chrootenv =3D=3D NULL) { >> >> I would think there would be a reason for not really using chroot(2) >> here, such as preparing images as non-root. >> >> -- >> Regards, >> Bryan Drewery >> >=20 --=20 Xin LI https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die --4fHAqkBBRaXfFUoEPB2lxEwUlX5kUpdr6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.1.8 (FreeBSD) iQIcBAEBCgAGBQJWLtKAAAoJEJW2GBstM+ns3VAP/RcaHOdnMYdpXtjzyifin0E7 PuCRJBZ/QLRG9jI+g6KkGQlXtj5DX8K33FBOoenolJAS1peZ3kNuO2Q8lOCLUr/L Feldx49gA50TQyPgvCWINWdSUVK+6Nc7rF7ETFM3RL9hCqZGJ8P1k2s7HmzgzxoJ UExXBzSgGprUVJFTh63oytcRYwhElvWa9XZOG8mMmL5GaAUziLeROqxi0vSExD33 cNdBsZKgTih087aFAvPENhNziULYWGrMaLKWnxlWA/xfNTXII53tlsAaJcVrVJdE hi/IhtmPDZr5fGS3+m9QLDoUcI4smVn+BnfAS/cQk7At8RB0kuYZ9En+jMB8pn/C MNn4OiP24DGKA/kk3okPJvcugLBLSEp1QfAAg2VUaK49AW3R2hkzcdmXYoXq4EXK 62Xvahz58UcjTl0GWiJu9bi0eMPdlKyE+LvWszd3RVjV5r+31FsCe8sp0hCVevsk JCjWBgeJgpXzsg2L+yv/1ORWhbIMvFFFQwOPCojMv0MpuCQz5SYRB3UAX0FEr489 myEQOLiircnhNesKO1FuBt5lJTvMBbBMSR9z/v8t/onmiyXjrAm1olH5CnButK+A v/TcZEHcUoYvh1LcH4Tu7rfY9vtUZgz162aen+deVO8pwrIXvOnCSJbSRP/KYD6q Thi8fzr03QBjDmRLRb1L =jT3W -----END PGP SIGNATURE----- --4fHAqkBBRaXfFUoEPB2lxEwUlX5kUpdr6--